PlanOrderingKey contains value portion of key-with-value-expression in order #2469
Comments
alecgrieser
added
bug
alecgrieser
added a commit
to alecgrieser/fdb-record-layer
that referenced
this issue
Jan 30, 2024
…y-with-value-expression in order This removes the value portion of a key-with-value expression from the `PlanOrderingKey` so that we do not attempt to order plans based on fields that do not actually contribute to the ordering of entries.
alecgrieser
added a commit
that referenced
this issue
Feb 27, 2024
…s multiple times (#2468) * Fixes #2462: PlanOrderingKey tripped up if the same expression appears multiple times This updates the handling for key expressions in `PlanOrderingKey` so that if the same expression appears multiple times, we only match it once. This fixes #2462. * Fixes #2469: PlanOrderingKey contains value portion of key-with-value-expression in order This removes the value portion of a key-with-value expression from the `PlanOrderingKey` so that we do not attempt to order plans based on fields that do not actually contribute to the ordering of entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current
PlanOrderingKeyimplementation will include the value components of aKeyWithValueExpressionwithin the professed ordering for a plan. This can result in plans that have an incorrect idea as to the order of returned results, which can lead to faulty unions and intersections. From what I can tell, this is not as much of a problem for a single index scan, as that may not need to look at thePlanOrderingKey.The text was updated successfully, but these errors were encountered: