Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calls to AsyncUtil static methods should pass in an executor where possible #2592

Closed
wshaib-apple opened this issue Mar 19, 2024 · 0 comments
Closed

Calls to AsyncUtil static methods should pass in an executor where possible #2592

wshaib-apple opened this issue Mar 19, 2024 · 0 comments
Assignees
@wshaib-apple

Comments

@wshaib-apple
Copy link
Contributor

We're using the shorter signatures of the static methods in AsyncUtil that don't take an executor and default to that thread pool. Probably worth a pass through the code to find those and make them use the Record Layer's FDB context's executor, just for consistency.
@wshaib-apple wshaib-apple self-assigned this Mar 19, 2024
ScottDugas added a commit that referenced this issue Mar 19, 2024
@ScottDugas
Merge pull request #2593 from wshaib-apple/pass_executor
dc11a49 
FIXES #2592: Calls to AsyncUtil static methods should pass in an exec…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wshaib-apple wshaib-apple

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wshaib-apple