Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Equality index scan can match additional suffix starting with zero byte #2650

Closed
MMcM opened this issue Apr 9, 2024 · 0 comments · Fixed by #2651
Closed

Equality index scan can match additional suffix starting with zero byte #2650

MMcM opened this issue Apr 9, 2024 · 0 comments · Fixed by #2651
Assignees
@MMcM
Labels
bug Something isn't working

Comments

@MMcM
Copy link
Contributor

MMcM commented Apr 9, 2024

The target key, used as a prefix, will end with \x00; the embedded zero will encode as \x00\xff and so match the prefix.
@MMcM MMcM self-assigned this Apr 9, 2024
@MMcM MMcM added the bug Something isn't working label Apr 9, 2024
MMcM added a commit to MMcM/fdb-record-layer that referenced this issue Apr 9, 2024
@MMcM
Fixes FoundationDB#2650: Equality index scan can match additional suf…
83ba8d0 
…fix starting with zero byte.

Stop an inclusive end with key+FF, not strinc(key).
MMcM added a commit to MMcM/fdb-record-layer that referenced this issue Apr 9, 2024
@MMcM
Fixes FoundationDB#2650: Equality index scan can match additional suf…
90bf819 
…fix starting with zero byte.

Stop an inclusive end with key+FF, not strinc(key).
MMcM added a commit to MMcM/fdb-record-layer that referenced this issue Apr 9, 2024
@MMcM
Fixes FoundationDB#2650: Equality index scan can match additional suf…
95103a5 
…fix starting with zero byte.

Stop an inclusive end with key+FF, not strinc(key).
MMcM added a commit to MMcM/fdb-record-layer that referenced this issue Apr 10, 2024
@MMcM
Fixes FoundationDB#2650: Equality index scan can match additional suf…
cf8bf28 
…fix starting with zero byte.

Stop an inclusive end with key+FF, not strinc(key).
@alecgrieser alecgrieser linked a pull request Apr 11, 2024 that will close this issue
Fixes #2650: Equality index scan can match additional suffix … #2651
Merged
alecgrieser pushed a commit that referenced this issue Apr 11, 2024
@MMcM
Fixes #2650: Equality index scan can match additional suffix … (#2651)
907aa19 
* Fixes #2650: Equality index scan can match additional suffix starting with zero byte.
Stop an inclusive end with key+FF, not strinc(key).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MMcM MMcM

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #2650: Equality index scan can match additional suffix … MMcM/fdb-record-layer
1 participant
@MMcM