Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index state reads should happen with a WANT_ALL streaming mode #881

Closed
alecgrieser opened this issue Apr 1, 2020 · 0 comments · Fixed by #882
Closed

Index state reads should happen with a WANT_ALL streaming mode #881

alecgrieser opened this issue Apr 1, 2020 · 0 comments · Fixed by #882
Assignees

Comments

@alecgrieser
Copy link
Contributor

When we read the index state as part of opening a record store, we currently perform a range read using the default streaming mode, which is ITERATOR, but we will end up waiting for all of them. For that reason, we should probably be reading those using the WANT_ALL streaming mode.

@alecgrieser alecgrieser self-assigned this Apr 1, 2020
alecgrieser added a commit to alecgrieser/fdb-record-layer that referenced this issue Apr 1, 2020
…T_ALL streaming mode

This configures the read of the index states as part of check version to read all the states using the `WANT_ALL` streaming mode. This should decrease the number of round trips to read all states. Note that we were already waiting for all results to come back anyway, so there is not the downside one sometimes get from using `WANT_ALL` where the time to first byte is lower.
@MMcM MMcM closed this as completed in #882 Apr 1, 2020
MMcM added a commit that referenced this issue Apr 1, 2020
Resolves #881: Index state reads should happen with a WANT_ALL streaming mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant