Fixes #1907: Sorting and comparing nested fields get confused #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normen662
previously approved these changes
Nov 17, 2022
Result of fdb-record-layer-pr-proto2 on Linux CentOS 7
|
Result of fdb-record-layer-pr-proto3 on Linux CentOS 7
|
…stedFieldOrComponentChild`. Each of these tests has two queries that should have identical plans. The first one matches with both planners (by means of that code in the old case). The second only currently passes with the Cascades planner (due to limitations of that same code).
* Equality comparisons take care of the corresponding key no matter where it occurs. * Some unconditional sort advances got out-of-sync. Fixes FoundationDB#1907: Sorting and comparing nested fields get confused
MMcM
force-pushed
the
and-with-then-sorting
branch
from
c62bd03
to
02a69bb
Compare
|
SonarCloud Quality Gate failed. |
Result of fdb-record-layer-pr-proto2 on Linux CentOS 7
|
Result of fdb-record-layer-pr-proto3 on Linux CentOS 7
|
normen662
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, add some tests that cover the advanceCurrentSort calls from
planNestedFieldOrComponentChild.Each of these tests has two queries that should have identical plans.
The first one matches with both planners (by means of that code in the old case).
The second only currently passes with the Cascades planner (due to limitations of that same code).
Then, redo how sort keys are tracked by and-with-then planner.