Resolves #302: Bump PMD version to 6.10.0 #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the ruleset with their new file locations and tweaks the exclusions so that it mostly matches are coding style/level of cleanliness. It also makes some changes to match a few rules that I thought should be updated.
MMcM
approved these changes
Jan 17, 2019
| public boolean isEquals() { | ||
| return low == high && low != null && | ||
| return low != null && TupleHelpers.equals(low, high) && | ||
| lowEndpoint == EndpointType.RANGE_INCLUSIVE && highEndpoint == EndpointType.RANGE_INCLUSIVE; |
There was a problem hiding this comment.
I suppose we could move these cheaper test earlier, but maybe the new TupleHelpers.equals is fast enough.
| @@ -74,6 +74,7 @@ | |||
| private RecordCursorResult<V> nextResult = RecordCursorResult.withNextValue(null, RecordCursorStartContinuation.START); | |||
|
|
|||
| @SpotBugsSuppressWarnings("EI_EXPOSE_REP2") | |||
| @SuppressWarnings("PMD.UnusedFormalParameter") // for compatibility reasons | |||
There was a problem hiding this comment.
I think it may actually be a bug, but this is okay until that gets settled.
|
one more run before merging to make sure no skew test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the ruleset with their new file locations and tweaks the exclusions so that it mostly matches our coding style/level of cleanliness. It also makes some changes to match a few rules that I thought should be updated.
A few highlights:
Before merging, there should probably be one more rebase from master (as this is prone to merge skew), and once it's merged, all other PRs should probably rebase from it for similar reasons.