Replace small tray icons with larger ones and replace the new items icon #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Ahh this looks great—thank you! |
|
Also I'm gonna see if I can make that blue one a little brighter to match the Slack icon real quick - would be nice if it was that same teal color! :-) |
bengotow
added a commit
that referenced
this pull request
Mar 4, 2019
|
I don't know what happened but now that I upgraded to the latest version of Mailspring I now don't get either the notification or the icon change when an email arrives! And isn't possible to show unread mail count yet? For some reason that's what the setting says but it doesn't show any number. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tray icon indicating new messages is barely noticeable. Even a larger blue dot is hard to see. I replaced the icon with the mac version which is completely blue. I Also replaced the rest of them with larger icons (22px => 32px) so the are easier to distinguish.
Here you can see the new icons next to the old ones:
Empty Inbox:
New Items:
Inbox Full:
Fixes #1328