Fix/close x #2279
Merged
Fix/close x #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengotow
reviewed
Feb 14, 2021
| if (!this.isSpec) { | ||
| global.application.windowManager.quitWinLinuxIfNoWindows(); | ||
| // Tray indicator is switched off, therefore quitting the application. | ||
| app.quit(); |
There was a problem hiding this comment.
Hey @Phylu! I think this all looks great but I'm not sure offhand if this should be quit() or quitWinLinuxIfNoWindows(). Technically, this means that if you have the system tray turned off but two Mailspring windows open (the main window and a composer), and close the main window the app will quit. I think that's desirable but let's give it a spin and see!
bengotow
approved these changes
Feb 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2278.