Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated mailspring.appdata.xml.in to fix Flatpak version number and 100% checked pt-BR.json translation #2429

Merged

Conversation

matheusreich
Copy link
Contributor

The app/build/resources/linux/mailspring.appdata.xml.in file wasn't updated, and it caused issues on Flathub, where it automatically compiles Mailspring, but uses the mentioned file to present the current version and update (https://flathub.org/apps/details/com.getmailspring.Mailspring), as seen below:
image
Flathub's GitHub repository had an error about this very issue, and I've (hopefully) fixed it now.
The Brazilian Portuguese translation was good, but made use of a lot of different words to translate the same thing, which created a mix of meaning in pt-BR. Now, after fixing those issues, setting on a single standard and creating a more cohesive translation, I'd think that it is really good and standard throughout.

The mailspring.appdata.xml.in file is used by Flatpak to automatically build the containerized version, available in Flathub, and that file wasn't tracking Mailspring's version, showing then an older version on Flathub (main Flatpak store). Also, the Brazilian Portuguese translation is around 80% checked and corrected (also standardized a lot of different words that were the same thing, improving usability).
All of the pt-BR.json was checked and verified. I've applied the necessary corrections, and tried my best to fully standardize the entire translation, because same things were being translated to different things in Portuguese.
@matheusreich
Copy link
Contributor Author

The problem with the version number on Flathub is mentioned on flathub/com.getmailspring.Mailspring#10, where the maintainer suggests that fixing the aforementioned file with the correct info should get everything working when a new Mailspring update comes out.

@matheusreich
Copy link
Contributor Author

@bengotow If we could automatically update this file with the most recent version, as soon as it is compiled, we could get Flathub to also be up-to-date.

@bengotow
Copy link
Collaborator

bengotow commented Oct 9, 2022

Hey thanks for contributing this @matheusreich! I'll add updating this to our my build workflow and we can look at automating it in the future.

@bengotow bengotow merged commit c4f2e1a into Foundry376:master Oct 9, 2022
@matheusreich
Copy link
Contributor Author

You're welcome @bengotow! It is my small help in getting Mailspring to as many places as possible, and given that Flatpak is widely used in many Linux distros, it is important to keep everything working smoothly! Keep up your great work, Mailspring is awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants