Composer image resize - Community#729 #2440
Merged
+243
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: check how to undo AND see if title/alt attribute implementation is possible (maybe a pop-up with fields for these AND width and height 🤷♂️)
The composer is adding styles to inline images, this means a draft can look completely different to the received mail. Removed the `vertical-align` and reset the `margin` to match the email view
- Added image ratio retention (<kbd>shift</kbd> = freeform) - Fixed resizing being stopped when reducing the image size reduces the height of the email - Had to stop the container from reducing (whilst resizing) as reducing the image inside a reducing element was VERY janky 🤮
|
This pull request has been mentioned on Mailspring Community. There might be relevant details there: https://community.getmailspring.com/t/resizing-image-in-composer/729/6 |
bengotow
approved these changes
Dec 29, 2022
There was a problem hiding this comment.
Wow this looks great, nice work @glenn2223! Going to merge this and we'll ship an update :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add image resizing to the composer - closes Community#729
before it was padded and top-aligned then, in the viewer, it would have no padding and be base-aligned - meaning what you see is not what they get 😉