Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Unicode handling in song titles and artists #275

Merged
merged 1 commit into from
May 5, 2024

Conversation

Founntain
Copy link
Owner

Removed Unicode handling from specific MapEntry classes and centralized it in MapEntryBase class. Also added an option in the settings to allow users to display titles and artists using their respective Unicode characters. This gives users more display options. Fixes #274

New Setting:
327962008-30157397-0bae-497f-948a-27795cc555cc

Screenshots:
327961904-01fd2e13-4a93-480f-9e9d-d6a10266a912
327961930-5bb69d6e-3f17-4f12-8e19-f6308d40fe14
327961939-da6ee1b2-9b9e-48c2-8b69-7a5ba4950211

Removed Unicode handling from specific MapEntry classes and centralized it in MapEntryBase class. Also added an option in the settings to allow users to display titles and artists using their respective Unicode characters. This gives users more display options.
@Founntain Founntain added bugfix pull request that fixes a bug refactor Pull request that refactors the code UI Everything that has anything related to the UI labels May 4, 2024
@Founntain Founntain requested a review from Cesan May 4, 2024 16:38
@Founntain Founntain changed the title Refactor Unicode handling in song titles and artists Fixed Unicode handling in song titles and artists May 4, 2024
Copy link
Collaborator

@Cesan Cesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is good

@Founntain Founntain merged commit 06f1904 into master May 5, 2024
4 checks passed
@Founntain Founntain deleted the unicode-titles branch May 5, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix pull request that fixes a bug refactor Pull request that refactors the code UI Everything that has anything related to the UI
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[REQUEST] Metadata in original language
2 participants