Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Keep in-support Ruby versions in matrix #110

Merged
merged 1 commit into from Jan 31, 2024
Merged

CI: Keep in-support Ruby versions in matrix #110

merged 1 commit into from Jan 31, 2024

Conversation

olleolleolle
Copy link
Collaborator

@olleolleolle olleolleolle commented Jan 30, 2024 •
edited by ivanoblomov

Goal

Keep the gem working on latest Ruby versions.

Approach

  1. Drop EOL'd Ruby versions.
  2. Use latest version of a GitHub Action (to avoid deprecation warnings in CI output).
  3. Add in-support Ruby versions.

Signed-off-by: Olle Jonsson olle.jonsson@gmail.com

ivanoblomov
ivanoblomov approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@ivanoblomov ivanoblomov left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was debating whether we should cut off support to old rubies--before realizing this just affects CI. Doh!

Thanks for staying on top of this.

@ivanoblomov ivanoblomov added the CI Continuous Integration label Jan 30, 2024
@olleolleolle olleolleolle merged commit a1029bc into master Jan 31, 2024
4 checks passed
@olleolleolle olleolleolle deleted the olleolleolle-patch-1 branch January 31, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanoblomov ivanoblomov ivanoblomov approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olleolleolle @ivanoblomov