Skip to content
This repository has been archived by the owner on May 4, 2023. It is now read-only.

Update French translation #218

Merged
merged 2 commits into from Oct 25, 2022
Merged

Update French translation #218

merged 2 commits into from Oct 25, 2022

Conversation

xerta555
Copy link
Contributor

No description provided.

@xerta555
Copy link
Contributor Author

Need to be translated

Screenshot_20221023-193638.jpg

Need to be improved

Screenshot_20221023-193931.jpg

@androidacy-user
Copy link
Collaborator

@xerta555 looks like you need some more work. Build fails with your updates

@androidacy-user androidacy-user added the in progress This is being worked on label Oct 24, 2022
@xerta555
Copy link
Contributor Author

@xerta555 looks like you need some more work. Build fails with your updates

Need to be translatable
image

@Fox2Code
Copy link
Owner

@android:string/something is a reference to a system resource, replace it directly by Something instead.

@xerta555
Copy link
Contributor Author

@android:string/something is a reference to a system resource, replace it directly by Something instead.

But it must be translated...

@androidacy-user
Copy link
Collaborator

@xerta555 looks like you need some more work. Build fails with your updates

Need to be translatable image

You're trying to reference another (nonexistent) string within a string which won't work. Directly put the translation instead of any @android notation

@xerta555
Copy link
Contributor Author

@xerta555 looks like you need some more work. Build fails with your updates

Need to be translatable image

You're trying to reference another (nonexistent) string within a string which won't work. Directly put the translation instead of any @android notation

Ok but how to translate "yes" "no" and "cancel" so ?

@androidacy-user
Copy link
Collaborator

@xerta555 looks like you need some more work. Build fails with your updates

Need to be translatable image

You're trying to reference another (nonexistent) string within a string which won't work. Directly put the translation instead of any @android notation

Ok but how to translate "yes" "no" and "cancel" so ?

Just put the string where you have the @android stuff now and maybe remove translateable=false

@xerta555
Copy link
Contributor Author

Just put the string where you have the @android stuff now and maybe remove translateable=false

I hesitate to do that but i don't want to break more things

@Fox2Code
Copy link
Owner

This is valid:

    <string name="yes" translatable="false">Oui</string>
    <string name="no" translatable="false">Non</string>
    <string name="cancel" translatable="false">Annuler</string>

@xerta555
Copy link
Contributor Author

This is valid:

    <string name="yes" translatable="false">Oui</string>
    <string name="no" translatable="false">Non</string>
    <string name="cancel" translatable="false">Annuler</string>

Done now.

@Fox2Code
Copy link
Owner

Thank you! :3

@Fox2Code Fox2Code merged commit dc58ee6 into Fox2Code:master Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in progress This is being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants