Updated yaml.safeDump and List.vue sortable table #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…view to make the table sortable
This was referenced Dec 30, 2022
|
Closing as I believe you mentioned you resolved this in the .04 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current import/export appears to be broken. It looks like yaml.safeDump has been removed for yaml.dump. On the latest, I could export a JSON backup, but not a YAML one. Also both imports appear to be broken. I only get a "0 items imported".
HOWEVER, with this change, you at least get the error.yml file downloaded that explains what happened. This was not working before.
I also thought it was a nice touch to allow the item list to be sortable. This way if you want to sort by name, location, or whatever other header you can easily do so.