Why did you take dist out of source?

[mgd216]

Greetings, using angular-toastr through bower. You recently took dist out of source, but your bower file points to:

"main": [
"./dist/angular-toastr.tpls.js",
"./dist/angular-toastr.css"
],

Can you please either correct the bower.json or put /dist back in? Thanks.

[KvChaos]

dist was added to .gitignore, so bower_install now doesn't send down /dist.

[Foxandxss]

Ouch! I forgot about bower!

Main reason I took /dist out is because people sends PRs and the change /dist too and makes the merge of the PR a pain.

Another reason was not really needing it, but I forgot about bower.

That being said, why are you using bower? Bower is "deprecated" and all the new libraries are not supporting bower anymore. I am considering dropping bower support as well.

[mgd216]

Thanks for the quick reply, unfortunately our application is using a
template called INSPINA from WrapBootstrap. The Angular version of that
template uses angular-toastr.

While I agree, would love to move away from bower, we are stuck on this
template for awhile. If you could reload the /dist directory it would be
greatly appreciated. Thanks.

On Sun, Aug 21, 2016 at 3:33 PM, Jesús Rodríguez notifications@github.com
wrote:

Ouch! I forgot about bower!

Main reason I took /dist out is because people sends PRs and the change
/dist too and makes the merge of the PR a pain.

Another reason was not really needing it, but I forgot about bower.

That being said, why are you using bower? Bower is "deprecated" and all
the new libraries are not supporting bower anymore. I am considering
dropping bower support as well.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#199 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAltBQqKtsjL4e0ZwxLooUnjT-wnhKwcks5qiKfxgaJpZM4JpXil
.

[Foxandxss]

Done, please tell me if that fixes it for you.

[mgd216]

Wow, thanks for the quick help. I see the dist in github, but there must
be a cached copy somewhere, bower install still pulling without /dist. No
worries though, with it checked in, should resolve soon. Again thanks for
the quick response.

On Sun, Aug 21, 2016 at 3:38 PM, Jesús Rodríguez notifications@github.com
wrote:

Done, please tell me if that fixes it for you.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#199 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAltBSjlR8L1JweuqoNCIRCrQMyTLDgyks5qiKlPgaJpZM4JpXil
.

[mgd216]

And BTW, with your point, we will start looking at trying to move this
template off bower dependency ;)

On Sun, Aug 21, 2016 at 3:43 PM, Matt Duvall mduvall@gmail.com wrote:

Wow, thanks for the quick help. I see the dist in github, but there must
be a cached copy somewhere, bower install still pulling without /dist. No
worries though, with it checked in, should resolve soon. Again thanks for
the quick response.

On Sun, Aug 21, 2016 at 3:38 PM, Jesús Rodríguez <notifications@github.com

wrote:

Done, please tell me if that fixes it for you.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#199 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAltBSjlR8L1JweuqoNCIRCrQMyTLDgyks5qiKlPgaJpZM4JpXil
.

[KvChaos]

Absolutely, thanks Foxandxss! Appreciate the quick reply on a Sunday!

[Foxandxss]

Ill probably need to make a new release, bower is a bit dumb on this. Please try again, say in an hour and I will make a new release if needed.

[kenzik]

+1 - Just noticed this. Glad it's covered.

[RobEDarling]

Hey Guys - Just an FYI - tried this via bower now and the release still does not contain dist.

[Foxandxss]

Fixed.

[RobEDarling]

Thanks!! Appreciate it!