Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #15: Support Toastr newestOnTop configuration option #16

Closed
wants to merge 1 commit into from

Conversation

bvaughn
Copy link

@bvaughn bvaughn commented Aug 11, 2014

No description provided.

@Foxandxss
Copy link
Owner

I need to research more.

I didn't include this option at first because there was a limitation on $animate.enter and technically it would allow append and prepend with the time.

I need to research if there is a cleaner way to fix it, and if not, check yours, but so far it doesn't have any test and it broke a few.

@bvaughn
Copy link
Author

bvaughn commented Aug 11, 2014

Oh, my bad for breaking the build. I didn't anticipate that change to impact anything since it was (I thought) fully backwards compatible.

I would be happy to update the tests to fix the break, if you'd consider this addition. If you'd rather not add this feature I won't bother. Just let me know! :)

@Foxandxss
Copy link
Owner

I do want the feature, it is on my todo list (issue #1) but I need to find the best way that could be native $animate.enter support or your PR.

@Foxandxss
Copy link
Owner

It is really really easy to do on 1.3 with $animate, so I am not sure if I backport that, workaround that or leave it for 1.3 only.

I need to think :P

@Foxandxss
Copy link
Owner

For what is worth, your patch is not working for me:

failure

@Foxandxss
Copy link
Owner

I am going to close this PR because it was brokish.

On the other hand, now that I decided to remove 1.2 support, I am going to implement this on the new version.

@Foxandxss Foxandxss closed this Oct 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants