Adding a "refresh timer" to the scope

[jcford73]

Adding a method to restart the timeout timer to keep a toast visible longer.

[Foxandxss]

A toast is an alert, to say something, for me, it doesn't make sense to restart the timer.

If an user needs to read it, they can hover it so it doesn't go away.

[jcford73]

My use case is uploading multiple files. Instead of opening a screen full of toasts to announce that each uploaded successfully, I'm showing one toast and if it's still visible when the next file finishes, I'm updating the message and resetting the timer.

[Foxandxss]

I get you. I will think about that.

[jcford73]

Do you know of any other way to accomplish what I'm trying? Currently, the toast continues to update until it times out and then another one immediately pops up with a new timer. It works okay, but the flicker when it has to pop a new toast is just a bit ugly.

[Foxandxss]

I would make a permanent toast for the time being and after all upload finishes, kill the toast.

[jcford73]

Yes that would sort of work. Except then if there were only a few small files, the toast would disappear too quickly.

[Foxandxss]

I want this option, but having a method in the current scope is just one step, To access it you need to myToast.scope.refreshTimer() and I don't really like that API.

Also, I need tests.

[jcford73]

I agree about having to go through the scope property to refresh the timer.

To be consistent with the rest of the API, it should probably go through the service like toastr.refreshTimer(toast) unless you want a shorter method name. Maybe toastr.extend(toast)? Or toastr.prolong(toast)?

[Foxandxss]

Perhaps just "restart"?

[jcford73]

Could that give the impression it affects more than just the timer?

[Foxandxss]

You are right. Then refreshTimeout or simply refresh ?

[jcford73]

I'll just keep refreshTimeout for maximum clarity.

Another topic: Tests are in toastr_spec.js but I haven't figured out how to run them locally.

[Foxandxss]

For the tests, you need to run testem. I need to swap that for karma.

So for today:

$ npm install -g testem
$ testem -f config/testem.json

The tests will watch any change that comes from $ gulp.

[Foxandxss]

Nice work on that, but we would need a few more tests cases where the toast is not there (long gone) and one where the toast was just gone one millisecond ago.

[jcford73]

Will do.

[jcford73]

Are the tests sufficient? Are there any other test cases needed?

[Foxandxss]

Probably yes. Will double check tomorrow and release this weekend :)

[Foxandxss]

Thanks, I merged this. I will make a release.