Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change progressBar directive name to avoid conflicts #240

Closed
wants to merge 2 commits into from
Closed

Change progressBar directive name to avoid conflicts #240

wants to merge 2 commits into from

Conversation

manuelpuyol
Copy link

Since porgressBar is a fairly common directive name in lots of applications, I've changed its name to toastProgressBar avoiding conflicts in most cases.
Also, I've fixed the broken test updating the error text.

@manuelpuyol
Copy link
Author

@Foxandxss any way to merge and release this? It's quite simple

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manuelpuyol @lushgoose