Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow enrolling custom db and KEK certs #217

Merged
merged 1 commit into from
May 14, 2023

Conversation

Cornelicorn
Copy link
Contributor

Closes #190.

@Cornelicorn
Copy link
Contributor Author

The hardcoded Owner UUID is just a placeholder.
I'm not sure if the Owner UUID should be dynamically associated with every certificate, set once for all custom certificates (statically in sbctl or read from the filesystem as the certificates) or the existing UUID (/usr/share/secureboot/GUID) should be reused

@Foxboron
Copy link
Owner

I think utilizing a custom GUID for this is fine. It makes it easier to make assumptions on when looking at the signature database.

@Cornelicorn
Copy link
Contributor Author

I think utilizing a custom GUID for this is fine. It makes it easier to make assumptions on when looking at the signature database.

Ok, I put in a newly generated UUID (instead of the tpm-eventlog one incremented by 1).

@Cornelicorn Cornelicorn marked this pull request as ready for review May 11, 2023 14:47
@Foxboron
Copy link
Owner

If you want an additional challenge, you could try to write a test for this using the virtual filesystem layer sbctl has :)

Example: https://github.com/Foxboron/sbctl/blob/master/cmd/sbctl/status_test.go

If you don't have time that is fine as well, but getting more test coverage would be cool.

@Cornelicorn
Copy link
Contributor Author

You mean a test to check that enrolling custom certificates works?

@Foxboron
Copy link
Owner

Yep :)

@Cornelicorn
Copy link
Contributor Author

After looking through the testing suite, I don't think that's quite doable for me right now (It's the first time for me to work with go), sorry.

@Foxboron
Copy link
Owner

That is fine :) No worries!

@Cornelicorn
Copy link
Contributor Author

I think GitHub still wants a separate approval for the workflow runs, besides the PR review.

@Foxboron
Copy link
Owner

Thanks for implementing this :)

@Foxboron Foxboron merged commit b2aece3 into Foxboron:master May 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for custom OEM keys
2 participants