-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow enrolling custom db and KEK certs #217
Conversation
The hardcoded Owner UUID is just a placeholder. |
I think utilizing a custom GUID for this is fine. It makes it easier to make assumptions on when looking at the signature database. |
Ok, I put in a newly generated UUID (instead of the tpm-eventlog one incremented by 1). |
If you want an additional challenge, you could try to write a test for this using the virtual filesystem layer Example: https://github.com/Foxboron/sbctl/blob/master/cmd/sbctl/status_test.go If you don't have time that is fine as well, but getting more test coverage would be cool. |
You mean a test to check that enrolling custom certificates works? |
Yep :) |
After looking through the testing suite, I don't think that's quite doable for me right now (It's the first time for me to work with go), sorry. |
That is fine :) No worries! |
I think GitHub still wants a separate approval for the workflow runs, besides the PR review. |
Thanks for implementing this :) |
Closes #190.