Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dbx Key Management #236

Merged
merged 5 commits into from
Aug 10, 2023
Merged

Dbx Key Management #236

merged 5 commits into from
Aug 10, 2023

Conversation

RiSKeD
Copy link
Contributor

@RiSKeD RiSKeD commented Aug 9, 2023

Enrollment/Rotation/Reset of dbx keys.

Fabian Wienand added 5 commits August 3, 2023 15:36
Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>
Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>
Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>
Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>
@RiSKeD RiSKeD mentioned this pull request Aug 9, 2023
@Foxboron Foxboron merged commit 99e260c into Foxboron:master Aug 10, 2023
2 checks passed
@Foxboron
Copy link
Owner

Thanks!

@Foxboron
Copy link
Owner

@RiSKeD So, I should have caught this during review but the dbx implementation here doesn't really make sense.

Creating a key and expecting it to be enrolled is not really how we use dbx in UEFI, it should be a revocation list and be specially handled. Currently it's breaking key enrollment for enroll-keys.

I'll need to partially revert this patch, but if you can explain how you are currently using this feature I can try and not break it for your usecase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants