Add append option #244
Merged
Add append option #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>
RiSKeD
force-pushed
the
add-append-option
branch
from
a803d3b
to
8733e65
Compare
Cornelicorn
reviewed
Sep 14, 2023
cmd/sbctl/reset.go
Outdated
| @@ -150,6 +207,7 @@ func RunReset(cmd *cobra.Command, args []string) error { | |||
| func resetKeysCmdFlags(cmd *cobra.Command) { | |||
| f := cmd.Flags() | |||
| f.VarPF(&resetCmdOpts.Partial, "partial", "p", "reset a partial set of keys") | |||
| f.StringVarP(&resetCmdOpts.CertFiles, "cert-files", "c", "", "optional paths to certificate file to remove from db (seperate individual paths by ';')") | |||
There was a problem hiding this comment.
This may not only be db, but also other variables, right? Even though the function is called the same, this seems a bit confusing to me from the wording
There was a problem hiding this comment.
right, db is referring to the cert database of any hierarchy, the wording is a bit off there.
RiSKeD
force-pushed
the
add-append-option
branch
from
8733e65
to
b19c29a
Compare
…e reset Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>
RiSKeD
force-pushed
the
add-append-option
branch
from
b19c29a
to
fb65331
Compare
|
Missing a section in the manpage :) https://github.com/Foxboron/sbctl/blob/master/docs/sbctl.8.txt#L35 |
Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>
I added comments for each of the flags I added. |
Foxboron
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added one more flags to enroll-keys and reset respectively:
Enroll-keys: Append the key to be enrolled to the existing db
Reset: Only remove a specific certs by providing a flag with their paths
I am hesitant to add more flags to the enroll-keys cmd but they do seem useful to me