BUGFIX: f.StringVarP() was clearing the exportPath/databasePath strings #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foxboron
approved these changes
Dec 11, 2023
spillner
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
spillner
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
spillner
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how
sbctl createever worked with the default paths--- the var {} block initially sets exportPath/databasePath to the default values from the sbctl module, but then pflag.StringVarP() overwrote them with empty string passed in as thevalueparameter. From https://github.com/spf13/pflag/blob/master/string.go it looks like that has been the behavior for a long time.Fixed by passing the values from sbctl as the initialization value in StringVarP().