Deployment via Docker #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominique-boerner
force-pushed
the
Docker
branch
from
711c464
to
393a293
Compare
* created api.Dockerfile for the fox-deck-api * created app.Dockerfile for the fox-deck-app * create docker-compose.yml for connecting both apps via network * use 'bcryptjs' instead of 'bcrypt'
dominique-boerner
force-pushed
the
Docker
branch
from
393a293
to
394a694
Compare
We had some errors because we copied the 'node_modules' of both applications. Now we are ignoring both 'node_modules' which lets us use the c++ implementation of 'bcrypt' again. Now, the 'npm rebuild' is not necessary anymore. This makes building the docker containers also much faster.
dominique-boerner
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.