remove subtitles ?

[ycardon]

Hello,

Thanks again for your work.

I've got a question : now some of the tv shows give me "incrusted" subtitles (in color blue / red / yellow, reminds me of teletext). As they are french subtitles on french voice, it's not very useful for me.

Do you have the same ?
Do you have any idea on how to remove them ?

Yann

[Fra-Ktus]

Hi Yann,

Yes the subtitle are burned into the video but sometimes they have also
clean version.
It's just that I need them :-)

I will see what I can do, maybe giving a menu so that you can choose the
stream or try to have a preference.

Best regards,

Marco Hinic
CEO & Software Architect
http://www.arkaospro.com

This email and any attachments are confidential. It may contain privileged
information and it is intended for the named recipient(s) only. It must not
be distributed without consent. If you have received this email by mistake,
please notify the sender and destroy any copies of this information.

On Sun, Jun 26, 2016 at 1:46 PM, Yann notifications@github.com wrote:

Hello,

Thanks again for your work.

I've got a question : now some of the tv shows give me "incrusted"
subtitles (in color blue / red / yellow, reminds me of teletext). As they
are french subtitles on french voice, it's not very useful for me.

Do you have the same ?
Do you have any idea on how to remove them ?

Yann

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#2, or mute the thread
https://github.com/notifications/unsubscribe/AJ3lkPzmAt750Sv27nSJ7wOkOvD9FpFjks5qPmangaJpZM4I-ifp
.

[ycardon]

Ah... if this is a feature and not a bug, it's different ^^

Also we could just have a fork of the project without the subtitles if it's quicker to implement.

I was searching in your sources but I got lost (and lazy)...
Maybe can you give me a hint on where I have to look ?

Yann

[Fra-Ktus]

I log them when parsing the code, it looks like

2016-07-02 18:10:29,991 (10f8f6000) : DEBUG (networking:166) - Requesting 'http://concert.arte.tv/fr/player/58121'
2016-07-02 18:10:30,266 (10f8f6000) : INFO (ServiceCode:105) - ARTE +7 possible url http://arteconcert.gl-systemhaus.de/am/concert/068000/068900/068966-000-B_MQ_0_VO_02400677_MP4-300_AMM-ALW.mp4
2016-07-02 18:10:30,266 (10f8f6000) : INFO (ServiceCode:106) - ARTE +7 possible bitrate 300
2016-07-02 18:10:30,266 (10f8f6000) : INFO (ServiceCode:107) - ARTE +7 possible version code "VO"
2016-07-02 18:10:30,267 (10f8f6000) : INFO (ServiceCode:105) - ARTE +7 possible url http://arteconcert.gl-systemhaus.de/am/concert/068000/068900/068966-000-B_HQ_0_VO_02400680_MP4-800_AMM-ALW.mp4
2016-07-02 18:10:30,267 (10f8f6000) : INFO (ServiceCode:106) - ARTE +7 possible bitrate 800
2016-07-02 18:10:30,267 (10f8f6000) : INFO (ServiceCode:107) - ARTE +7 possible version code "VO"
2016-07-02 18:10:30,267 (10f8f6000) : INFO (ServiceCode:105) - ARTE +7 possible url http://arteconcert.gl-systemhaus.de/am/concert/068000/068900/068966-000-B_EQ_0_VO_02400678_MP4-1500_AMM-ALW.mp4
2016-07-02 18:10:30,267 (10f8f6000) : INFO (ServiceCode:106) - ARTE +7 possible bitrate 1500
2016-07-02 18:10:30,268 (10f8f6000) : INFO (ServiceCode:107) - ARTE +7 possible version code "VO"
2016-07-02 18:10:30,268 (10f8f6000) : INFO (ServiceCode:105) - ARTE +7 possible url http://arteconcert.gl-systemhaus.de/am/concert/068000/068900/068966-000-B_SQ_0_VO_02400679_MP4-2200_AMM-ALW.mp4
2016-07-02 18:10:30,268 (10f8f6000) : INFO (ServiceCode:106) - ARTE +7 possible bitrate 2200
2016-07-02 18:10:30,268 (10f8f6000) : INFO (ServiceCode:107) - ARTE +7 possible version code "VO"
2016-07-02 18:10:30,269 (10f8f6000) : INFO (ServiceCode:109) - ARTE +7 found url 4

It's in the com.plexapp.system.log on the server in
/Volumes/ your login /Library/Logs/Plex Media Server/PMS Plugin Logs

It's decided in the ServiceCode.pys in the GetVideoLangURL at the end of the function before the
return video_url
It uses the version code to decide.
There could be a preference panel to decide, I will see if I can make that happen...

[ycardon]

Thanks a lot, it's working right for me now !

I tested different video, I had :

• VOF, VA, VOF-STMF
• VOA, VF
• VOA, VF-STF

I removed the first rule that was matching the last "VOF-STMF".
On the second rule, I've retained the version codes I wanted and added escaped quotes around "VOF" and "VF".

Maybe we can set a more robust way of choosing the version codes with an ordered preference list (for instance : VOF then VF then VOF-STMF then VF-STF...)

  # now see if we get something that match what we need...
  for url in urls:
    if (url.bitrate > 2000):
      #if url.version_code.find(lang)>=0:
      #  video_url = url.url
      if url.version_code in ("\"VOF\"", "\"VF\"", "\"VF-STF\""):
        video_url = url.url
  return video_url