Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PluginHelper.getPluginSaveFile() outside loop #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

willglynn
Copy link

I'm noticing a significant performance degradation as my career-mode game progresses. This may not be related, but at the very least we don't need to parse the config file once per vessel per microwave receiver.

@Joeppie
Copy link

Joeppie commented Jun 8, 2014

I have had the same issue. I was suprised to find a new non-carreer game having much better performance all-round. This definitely should be considered.

@williamh42
Copy link

I just submitted a pull request for another career mode slowdown related to checking for techs for upgrades that is similar to this - glancing at this it looks like this bug could be even more thoroughly squashed (with a substantial performance improvement) by simply caching the ConfigNode and only reading it in if the cached object is for some reason destroyed - from what I can tell the plugin save file shouldn't ever be modified by anything other than KSPInterstaller's own code correct? I might try that myself unless someone knows of a problem that might cause...

Either way this is a good, and very simple fix.

@Boris-Barboris
Copy link

#72

Spent a couple of hours on microwave code refactoring. There is no need now in FS operations at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants