Faster python driver incremental builds #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took over a minute to re-install the python inky drivers' requirements.
After this PR we install "vendor drivers" in a shared
/srv/frameos/vendor/inkyPythonstyle folders, instead of per-release folders like now. This allows us to easily cache dependencies between steps if nothing changes. Symlinking python venvs wasn't a better option.As a result, the second install of the inky python drivers now takes less than a second. It used to always add a minute to the deployment time. The python hyperpixel brightness controls are now equally fast to update.
I did some other cleanup in the PR as well.
A full (incremental) redeploy, from SSH connection established to connection closed, including on device compilation and linking, for a Raspberry Pi Zero W2 and an Inky impressions frame now takes 71 seconds... or 60 seconds exactly without the restart in the end.