feat(Downloads): Improve efficiency and functionality #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lezoudali
reviewed
Jun 9, 2021
lezoudali
reviewed
Jun 9, 2021
jhodges10
force-pushed
the
jh/new-download-improvements
branch
2 times, most recently
from
9be0bed
to
c367473
Compare
Add helper functions to simplify a couple of tasks Fix FrameioHelpers class Fix FrameioHelpers import Fix __init__ imports Finish fixing helpers... Don't do multi-part downloads on files smaller than 25 MB Add download improvements from strombergdev Fix extra prefix in client.assets.download() Tweak download function Fix missing call to _get_path() to set self.destination Add test to Makefile Fix download function's keyword via ** keyword args Don't do multi-part downloads on files smaller than 25 MB
jhodges10
force-pushed
the
jh/new-download-improvements
branch
from
c367473
to
c302ec0
Compare
Open
jhodges10
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVREL-643
Description:
replaceboolean for replacing assets at downloadDepends on:
Includes changes from:
Feedback requested: