New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2018-2019 pp changes #40
Conversation
5a0d1b7
to
c74662f
Compare
gonna use this branch for all the pp changes, WIP... |
d5dfb06
to
9e77d68
Compare
weird, if i remove the angle bonus from speed pp it matches smoogi's xexxar-all site pretty closely, but with the angle bonus in speed pp it gives way too big values. guess i'll wait, maybe xexxar-all isn't updated |
it might also be that due to the lack of slider calculations, the angle value is off enough to mess it up, will try to approximate slider tail |
seems closer now, will still try approximating slider tails though |
nevermind i fixed it, now it matches smoogi's site closely B) |
note to self: squash all commits after 4f375ab before merging |
need to add this ppy/osu-performance@2f0fc7b |
also need to check if the latest commits here affect anything ppy/osu#3839 |
now that I look at it more closely it seems to be just a refactor and effectively does nothing |
seems like it's just refactoring, guess ill start porting this to other versions of oppai |
f10215b
to
5a1787e
Compare
cleaned up commit history |
Dad pp is finalized, pls push :* |
cant yet because not all scores are recalculated (for example freedom dive is still 820) |
sooo defenders is quite a bit off, ill see if i can improve it before merging |
ooooh the high CS bonus was completely wrong, now it's close 👌 |
average error is 1.1%, worst error is 5.9% on death dance due to missing slider calcs. most maps arent that bad though, pretty happy with it |
rip fopen() |
don't merge until we have official data for the test suite