Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2018-2019 pp changes #40

Merged
merged 15 commits into from Feb 9, 2019
Merged

2018-2019 pp changes #40

merged 15 commits into from Feb 9, 2019

Conversation

Francesco149
Copy link
Owner

don't merge until we have official data for the test suite

@Francesco149 Francesco149 changed the title MBmasher fl rebalance 2018-2019 pp changes Jan 5, 2019
@Francesco149
Copy link
Owner Author

gonna use this branch for all the pp changes, WIP...

@Francesco149
Copy link
Owner Author

weird, if i remove the angle bonus from speed pp it matches smoogi's xexxar-all site pretty closely, but with the angle bonus in speed pp it gives way too big values. guess i'll wait, maybe xexxar-all isn't updated

@Francesco149
Copy link
Owner Author

it might also be that due to the lack of slider calculations, the angle value is off enough to mess it up, will try to approximate slider tail

@Francesco149
Copy link
Owner Author

seems closer now, will still try approximating slider tails though

@Francesco149
Copy link
Owner Author

nevermind i fixed it, now it matches smoogi's site closely B)

@Francesco149
Copy link
Owner Author

note to self: squash all commits after 4f375ab before merging

@Francesco149
Copy link
Owner Author

need to add this ppy/osu-performance@2f0fc7b

@Francesco149
Copy link
Owner Author

also need to check if the latest commits here affect anything ppy/osu#3839

@Francesco149
Copy link
Owner Author

need to add this ppy/osu-performance@2f0fc7b

now that I look at it more closely it seems to be just a refactor and effectively does nothing

@Francesco149
Copy link
Owner Author

also need to check if the latest commits here affect anything ppy/osu#3839

seems like it's just refactoring, guess ill start porting this to other versions of oppai

@Francesco149
Copy link
Owner Author

cleaned up commit history

@MaxKruse
Copy link

MaxKruse commented Feb 7, 2019

Dad pp is finalized, pls push :*

@Francesco149
Copy link
Owner Author

cant yet because not all scores are recalculated (for example freedom dive is still 820)

@Francesco149 Francesco149 mentioned this pull request Feb 7, 2019
@Francesco149
Copy link
Owner Author

sooo defenders is quite a bit off, ill see if i can improve it before merging

@Francesco149
Copy link
Owner Author

ooooh the high CS bonus was completely wrong, now it's close 👌

@Francesco149
Copy link
Owner Author

average error is 1.1%, worst error is 5.9% on death dance due to missing slider calcs. most maps arent that bad though, pretty happy with it

@MaxKruse
Copy link

MaxKruse commented Feb 9, 2019

rip fopen()

@Francesco149 Francesco149 merged commit fd3a6a5 into master Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants