Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing Space at a running cue should not stop it. #219

Open
musger opened this issue Nov 23, 2021 · 7 comments
Open

Pressing Space at a running cue should not stop it. #219

musger opened this issue Nov 23, 2021 · 7 comments

Comments

@musger
Copy link

musger commented Nov 23, 2021

Presing at a re-selected and already running cue currently stops it in 0.5.1 (and possibly later versions). This is possibly undocumented behavior, should not happen, and can cause unwanted errors in shows.

@FrancescoCeruti
Copy link
Owner

I do not plan to change this default behavior, but, in the upcoming version, it's possible to change the default "stop" action as "do nothing" to prevent what you described (stop/pause buttons are not affected by this)

This is possibly undocumented behavior

Yes, it's not explicitly stated in the documentation, it should be made more clear 👍

@musger
Copy link
Author

musger commented Nov 25, 2021

Is there a specific reason for not wanting to change this? To me the described issue seems to be a classic newbie pitfall. Changing the default "stop" action to prevent this sounds like a thing one would not do in the end after having already learned about this unexpecte behavior the hard way... I am sure the current behavior will almost always be discovered by mistake (even given the very recommended addition to the documentation).

fnetX added a commit to fnetX/linux-show-player that referenced this issue Nov 28, 2021
@clemradio
Copy link

I don't get it. How could we stop a cue then?

@musger
Copy link
Author

musger commented Dec 1, 2021 via email

@FrancescoCeruti
Copy link
Owner

The main reason for this behavior is that it's what I need in most of the shows I run, where certain scenes cannot be timed precisely and manually pausing or stopping a track is necessary.

Anyway I see your point, a different default might be more appropriate.

I'll think about what to do. Obviously any feedback by others is appreciated.

@fnetX
Copy link
Contributor

fnetX commented Dec 7, 2021

If the setting is changeable, it might be fine to alter the default. I also find myself having to stop a cue often, but when the default auto-advances, this is tricky anyway. And there were definitely shows where I accidentally stopped a running cue because I expected another one being selected :-( (But I didn't experience the newcomer problem, because I think I tested the software deeply before any show, so it was obvious to me how everything was supposed to work)

Another good option would be to have a global stop-this-cue-key which is different, so "Play" will always play and e.g. "Escape" or "End" (= skip to end) will stop the current key. So you know that you can safely tap those keys without accidentally launching the next cue if it was auto selected.

Also, a global stop-all might improve this situation.

@s0600204
Copy link
Contributor

s0600204 commented Dec 9, 2021

Obviously any feedback by others is appreciated.

Speaking for myself (running shows off a modified version of the develop branch): I set the spacebar action to "Faded Start", and use Esc as a global faded interrupt and Shift+Esc as a global hard-stop.

The only time I have to stop individual audio cues prematurely (and thus made use of the spacebar-stops-a-running-cue behaviour) is during the design/setup period - if I know I have to stop specific cues during a performance then I'll add stop cues.

(That said: the default behaviour of audio cues in the Cart Layout - tap to start and tap to stop - does make sense IMO. But then that layout doesn't hardcode spacebar as a keyboard shortcut.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants