forked from django-cms/django-cms
/
menu_page_viewperm.py
596 lines (542 loc) · 22.3 KB
/
menu_page_viewperm.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
# -*- coding: utf-8 -*-
from __future__ import with_statement
from cms.api import create_page
from cms.menu import CMSMenu, get_visible_pages
from cms.models import Page
from cms.models import ACCESS_DESCENDANTS, ACCESS_CHILDREN, ACCESS_PAGE
from cms.models import ACCESS_PAGE_AND_CHILDREN, ACCESS_PAGE_AND_DESCENDANTS
from cms.models.permissionmodels import GlobalPagePermission, PagePermission
from cms.models.titlemodels import Title
from cms.test_utils.testcases import SettingsOverrideTestCase
from django.contrib.sites.models import Site
from django.contrib.auth.models import AnonymousUser, User, Permission, Group
from django.db.models import Q
from django.test.client import Client
class ViewPermissionTests(SettingsOverrideTestCase):
"""
Test various combinations of view permissions pages and menus
Focus on the different grant types and inheritance options of grant on
Given the tree:
|- Page_a
|- Page_b
| |- Page_b_a
| |- Page_b_b
| | |- Page_b_b_a
| | | |- Page_b_b_a_a
| | |- Page_b_b_b
| | |- Page_b_b_c
| |- Page_b_c
| |- Page_b_d
| | |- Page_b_d_a
| | |- Page_b_d_b
| | |- Page_b_d_c
|- Page_c
|- Page_d
| |- Page_d_a
| |- Page_d_b
| |- Page_d_c
"""
GROUPNAME_1 = 'group_b_ACCESS_PAGE_AND_CHILDREN'
GROUPNAME_2 = 'group_b_b_ACCESS_CHILDREN'
GROUPNAME_3 = 'group_b_ACCESS_PAGE_AND_DESCENDANTS'
GROUPNAME_4 = 'group_b_b_ACCESS_DESCENDANTS'
GROUPNAME_5 = 'group_d_ACCESS_PAGE'
def setUp(self):
self.site = Site()
self.site.pk = 1
super(ViewPermissionTests, self).setUp()
def tearDown(self):
super(ViewPermissionTests, self).tearDown()
def _setup_tree_pages(self):
stdkwargs = {
'template': 'nav_playground.html',
'language': 'en',
'published': True,
'in_navigation': True,
}
page_a = create_page("page_a", **stdkwargs) # first page slug is /
page_b = create_page("page_b", **stdkwargs)
page_c = create_page("page_c", **stdkwargs)
page_d = create_page("page_d", **stdkwargs)
page_b_a = create_page("page_b_a", parent=page_b, **stdkwargs)
page_b_b = create_page("page_b_b", parent=page_b, **stdkwargs)
page_b_b_a = create_page("page_b_b_a", parent=page_b_b, **stdkwargs)
page_b_b_b = create_page("page_b_b_b", parent=page_b_b, **stdkwargs)
page_b_b_c = create_page("page_b_b_c", parent=page_b_b, **stdkwargs)
page_b_b_a_a = create_page("page_b_b_a_a", parent=page_b_b_a, **stdkwargs)
page_b_c = create_page("page_b_c", parent=page_b, **stdkwargs)
page_b_d = create_page("page_b_d", parent=page_b, **stdkwargs)
page_b_d_a = create_page("page_b_d_a", parent=page_b_d, **stdkwargs)
page_b_d_b = create_page("page_b_d_b", parent=page_b_d, **stdkwargs)
page_b_d_c = create_page("page_b_d_c", parent=page_b_d, **stdkwargs)
page_d_a = create_page("page_d_a", parent=page_d, **stdkwargs)
page_d_b = create_page("page_d_b", parent=page_d, **stdkwargs)
page_d_c = create_page("page_d_c", parent=page_d, **stdkwargs)
page_d_d = create_page("page_d_d", parent=page_d, **stdkwargs)
return [page_a,
page_b,
page_b_a,
page_b_b,
page_b_b_a,
page_b_b_a_a,
page_b_b_b,
page_b_b_c,
page_b_c,
page_b_d,
page_b_d_a,
page_b_d_b,
page_b_d_c,
page_c,
page_d,
page_d_a,
page_d_b,
page_d_c,
page_d_d,
]
def _setup_user_groups(self):
"""
Setup a group for every grant on ACCESS TYPE
"""
user = User.objects.create(username='user_1', email='user_1@domain.com', is_active=True, is_staff=True)
user.set_password(user.username)
user.save()
group = Group.objects.create(name=self.GROUPNAME_1)
group.user_set.add(user)
group.save()
user = User.objects.create(username='user_1_nostaff', email='user_1_nostaff@domain.com', is_active=True, is_staff=False)
user.set_password(user.username)
user.save()
group.user_set.add(user)
group.save()
user = User.objects.create(username='user_2', email='user_2@domain.com', is_active=True, is_staff=True)
user.set_password(user.username)
user.save()
group = Group.objects.create(name=self.GROUPNAME_2)
group.user_set.add(user)
group.save()
user = User.objects.create(username='user_2_nostaff', email='user_2_nostaff@domain.com', is_active=True, is_staff=False)
user.set_password(user.username)
user.save()
group.user_set.add(user)
group.save()
user = User.objects.create(username='user_3', email='user_3@domain.com', is_active=True, is_staff=True)
user.set_password(user.username)
user.save()
group = Group.objects.create(name=self.GROUPNAME_3)
group.user_set.add(user)
group.save()
user = User.objects.create(username='user_3_nostaff', email='user_3_nostaff@domain.com', is_active=True, is_staff=False)
user.set_password(user.username)
user.save()
group.user_set.add(user)
group.save()
user = User.objects.create(username='user_4', email='user_4@domain.com', is_active=True, is_staff=True)
user.set_password(user.username)
user.save()
group = Group.objects.create(name=self.GROUPNAME_4)
group.user_set.add(user)
group.save()
user = User.objects.create(username='user_4_nostaff', email='user_4_nostaff@domain.com', is_active=True, is_staff=False)
user.set_password(user.username)
user.save()
group.user_set.add(user)
group.save()
user = User.objects.create(username='user_5', email='user_5@domain.com', is_active=True, is_staff=True)
user.set_password(user.username)
user.save()
group = Group.objects.create(name=self.GROUPNAME_5)
group.user_set.add(user)
group.save()
user = User.objects.create(username='user_5_nostaff', email='user_5_nostaff@domain.com', is_active=True, is_staff=False)
user.set_password(user.username)
user.save()
group.user_set.add(user)
group.save()
user = User.objects.create(username='user_staff', email='user_staff@domain.com', is_active=True, is_staff=True)
user.set_password(user.username)
user.save()
self.assertEquals(11, User.objects.all().count())
def _setup_view_restrictions(self):
"""
Setup a view restriction with every type of the grant_on ACCESS_*
'group_b_ACCESS_PAGE_AND_CHILDREN'
'group_b_b_ACCESS_CHILDREN'
'group_b_ACCESS_PAGE_AND_DESCENDANTS'
'group_b_b_ACCESS_DESCENDANTS'
'group_d_ACCESS_PAGE'
"""
page = Page.objects.get(title_set__title="page_b")
group = Group.objects.get(name__iexact=self.GROUPNAME_1)
PagePermission.objects.create(can_view=True, group=group, page=page, grant_on=ACCESS_PAGE_AND_CHILDREN)
page = Page.objects.get(title_set__title="page_b_b")
group = Group.objects.get(name__iexact=self.GROUPNAME_2)
PagePermission.objects.create(can_view=True, group=group, page=page, grant_on=ACCESS_CHILDREN)
page = Page.objects.get(title_set__title="page_b")
group = Group.objects.get(name__iexact=self.GROUPNAME_3)
PagePermission.objects.create(can_view=True, group=group, page=page, grant_on=ACCESS_PAGE_AND_DESCENDANTS)
page = Page.objects.get(title_set__title="page_b_b")
group = Group.objects.get(name__iexact=self.GROUPNAME_4)
PagePermission.objects.create(can_view=True, group=group, page=page, grant_on=ACCESS_DESCENDANTS)
page = Page.objects.get(title_set__title="page_d")
group = Group.objects.get(name__iexact=self.GROUPNAME_5)
PagePermission.objects.create(can_view=True, group=group, page=page, grant_on=ACCESS_PAGE)
self.assertEquals(5, PagePermission.objects.all().count())
self.assertEquals(0, GlobalPagePermission.objects.all().count())
def assertPageFound(self, url, client=None):
if not client:
client = Client()
response = client.get(url)
self.assertEquals(response.status_code, 200)
def assertPageNotFound(self, url, client=None):
if not client:
client = Client()
response = client.get(url)
self.assertEquals(response.status_code, 404)
def assertNodeMemberships(self, visible_page_ids, restricted_pages, public_page_ids):
"""
test all visible page ids are either in_public and not in_restricted
or not in_public and in_restricted
"""
for page_id in visible_page_ids:
in_restricted = False
in_public = False
if page_id in restricted_pages:
in_restricted = True
if page_id in public_page_ids:
in_public = True
self.assertTrue((in_public and not in_restricted) or
(not in_public and in_restricted),
msg="page_id %s in_public: %s, in_restricted: %s" % (page_id, in_public, in_restricted))
def assertGrantedVisibility(self, all_pages, expected_granted_pages, username=None):
"""
helper function to check the expected_granted_pages are
not in the restricted_pages list and
all visible pages are in the expected_granted_pages
"""
# log the user in if present
user = None
if username is not None:
user = User.objects.get(username__iexact=username)
request = self.get_request(user)
visible_page_ids = get_visible_pages(request, all_pages, self.site)
self.assertEquals(len(visible_page_ids), len(expected_granted_pages))
public_page_ids = Page.objects.filter(title_set__title__in=expected_granted_pages).values_list('id', flat=True)
restricted_pages = Page.objects.exclude(title_set__title__in=expected_granted_pages).values_list('id', flat=True)
self.assertNodeMemberships(visible_page_ids, restricted_pages, public_page_ids)
def get_request(self, user=None):
# see tests/menu.py line 753
attrs = {
'user': user or AnonymousUser(),
'REQUEST': {},
'session': {},
}
return type('Request', (object,), attrs)
class ViewPermissionComplexMenuAllNodesTests(ViewPermissionTests):
"""
Test CMS_PUBLIC_FOR=all group access and menu nodes rendering
"""
settings_overrides = {
'CMS_MODERATOR': False,
'CMS_PERMISSION': True,
'CMS_PUBLIC_FOR': 'all',
}
def test_public_pages_anonymous_norestrictions(self):
"""
All pages are visible to an anonymous user
"""
all_pages = self._setup_tree_pages()
request = self.get_request()
visible_page_ids = get_visible_pages(request, all_pages, self.site)
self.assertEquals(len(all_pages), len(visible_page_ids))
def test_public_menu_anonymous_user(self):
"""
Anonymous user should only see the pages in the rendered menu
that have no permissions assigned,directly or indirectly
"""
self._setup_user_groups()
all_pages = self._setup_tree_pages()
self._setup_view_restrictions()
granted = ['page_a',
'page_c',
'page_d_a',
'page_d_b',
'page_d_c',
'page_d_d'
]
self.assertGrantedVisibility(all_pages, granted)
def test_menu_access_page_and_children_group_1(self):
"""
simulate behaviour of group b member
group_b_ACCESS_PAGE_AND_CHILDREN to page_b
"""
self._setup_user_groups()
all_pages = self._setup_tree_pages()
self._setup_view_restrictions()
granted = ['page_a',
'page_c',
#group_1
'page_b', #page_id b has page_id and children restricted - group 1
'page_b_a',
'page_b_b', #page_id b_b children restricted - group 2
'page_b_c',
'page_b_d',
# not restricted
'page_d_a',
'page_d_b',
'page_d_c',
'page_d_d'
]
self.assertGrantedVisibility(all_pages, granted, username='user_1')
client = Client()
login_ok = client.login(username='user_1', password='user_1')
self.assertEqual(login_ok , True)
url = "/en/page_b/"
self.assertPageFound(url, client)
url = "/en/page_b/page_b_b/"
self.assertPageFound(url, client)
# descendant
url = "/en/page_b/page_b_b/page_b_b_a/"
self.assertPageNotFound(url, client)
# group 5
url = "/en/page_d/"
self.assertPageNotFound(url, client)
# should be public as only page_d is restricted
url = "/en/page_d/page_d_a/"
self.assertPageFound(url, client)
def test_menu_access_children_group_2(self):
"""
simulate behaviour of group 2 member
GROUPNAME_2 = 'group_b_b_ACCESS_CHILDREN'
to page_b_b
"""
self._setup_user_groups()
all_pages = self._setup_tree_pages()
self._setup_view_restrictions()
granted = [
'page_a',
'page_c',
'page_b_b_a',
'page_b_b_b',
'page_b_b_c',
# not restricted
'page_d_a',
'page_d_b',
'page_d_c',
'page_d_d',
]
self.assertGrantedVisibility(all_pages, granted, username='user_2')
client = Client()
login_ok = client.login(username='user_2', password='user_2')
self.assertEqual(login_ok , True)
url = "/en/page_b/page_b_b/"
self.assertPageNotFound(url, client)
url = "/en/page_b/page_b_b/page_b_b_a/"
self.assertPageFound(url, client)
url = "/en/page_b/page_b_b/page_b_b_a/page_b_b_a_a/"
self.assertPageNotFound(url, client)
url = "/en/page_d/"
self.assertPageNotFound(url, client)
url = "/en/page_d/page_d_a/"
self.assertPageFound(url, client)
def test_menu_access_page_and_descendants_group_3(self):
"""
simulate behaviour of group 3 member
group_b_ACCESS_PAGE_AND_DESCENDANTS to page_b
"""
self._setup_user_groups()
all_pages = self._setup_tree_pages()
self._setup_view_restrictions()
granted = [ 'page_a',
'page_b',
'page_b_a',
'page_b_b',
'page_b_b_a',
'page_b_b_a_a',
'page_b_b_b',
'page_b_b_c',
'page_b_c',
'page_b_d',
'page_b_d_a',
'page_b_d_b',
'page_b_d_c',
'page_c',
'page_d_a',
'page_d_b',
'page_d_c',
'page_d_d',
]
self.assertGrantedVisibility(all_pages, granted, username='user_3')
client = Client()
login_ok = client.login(username='user_3', password='user_3')
self.assertEqual(login_ok , True)
url = "/en/page_b/"
self.assertPageFound(url, client)
url = "/en/page_b/page_b_d/page_b_d_a/"
self.assertPageFound(url, client)
url = "/en/page_d/"
self.assertPageNotFound(url, client)
url = "/en/page_d/page_d_a/"
self.assertPageFound(url, client)
def test_menu_access_descendants_group_4(self):
"""
simulate behaviour of group 4 member
group_b_b_ACCESS_DESCENDANTS to page_b_b
"""
self._setup_user_groups()
all_pages = self._setup_tree_pages()
self._setup_view_restrictions()
granted = [ 'page_a',
'page_b_b_a',
'page_b_b_a_a',
'page_b_b_b',
'page_b_b_c',
'page_c',
'page_d_a',
'page_d_b',
'page_d_c',
'page_d_d',
]
self.assertGrantedVisibility(all_pages, granted, username='user_4')
client = Client()
login_ok = client.login(username='user_4', password='user_4')
self.assertTrue(login_ok)
url = "/en/page_b/"
self.assertPageNotFound(url, client)
url = "/en/page_b/page_b_b/"
self.assertPageNotFound(url, client)
url = "/en/page_b/page_b_b/page_b_b_a/"
self.assertPageFound(url, client)
url = "/en/page_d/"
self.assertPageNotFound(url, client)
url = "/en/page_d/page_d_a/"
self.assertPageFound(url, client)
def test_menu_access_page_group_5(self):
"""
simulate behaviour of group b member
group_d_ACCESS_PAGE to page_d
"""
self._setup_user_groups()
all_pages = self._setup_tree_pages()
self._setup_view_restrictions()
granted = [ 'page_a',
'page_c',
'page_d',
'page_d_a',
'page_d_b',
'page_d_c',
'page_d_d',
]
self.assertGrantedVisibility(all_pages, granted, username='user_5')
client = Client()
login_ok = client.login(username='user_5', password='user_5')
self.assertTrue(login_ok)
# call /
url = "/en/page_b/"
self.assertPageNotFound(url, client)
url = "/en/page_b/page_b_b/"
self.assertPageNotFound(url, client)
url = "/en/page_b/page_b_b/page_b_b_a/"
self.assertPageNotFound(url, client)
url = "/en/page_d/"
self.assertPageFound(url, client)
url = "/en/page_d/page_d_a/"
self.assertPageFound(url, client)
class ViewPermissionTreeBugTests(ViewPermissionTests):
"""Test issue 1113
https://github.com/divio/django-cms/issues/1113
Wrong view permission calculation in PagePermission.objects.for_page
grant_on=ACCESS_PAGE_AND_CHILDREN or ACCESS_PAGE_AND_DESCENDANTS to page 6
Test if this affects the menu entries and page visibility
"""
settings_overrides = {
'CMS_MODERATOR': False,
'CMS_PERMISSION': True,
'CMS_PUBLIC_FOR': 'all',
}
GROUPNAME_6 = 'group_6_ACCESS_PAGE'
def _setup_pages(self):
"""
Tree Structure
|- Page_1
| |- Page_2
| |- Page_3
| |- Page_4 (false positive)
| |- Page_5
| | |- Page_6 (group 6 page access)
"""
stdkwargs = {
'template': 'nav_playground.html',
'language': 'en',
'published': True,
'in_navigation': True,
}
page_1 = create_page("page_1", **stdkwargs) # first page slug is /
page_2 = create_page("page_2", parent=page_1, **stdkwargs)
page_3 = create_page("page_3", parent=page_2, **stdkwargs)
page_4 = create_page("page_4", parent=page_3, **stdkwargs)
page_5 = create_page("page_5", parent=page_1, **stdkwargs)
page_6 = create_page("page_6", parent=page_5, **stdkwargs)
return [page_1,
page_2,
page_3,
page_4,
page_5,
page_6,
]
def _setup_user(self):
user = User.objects.create(username='user_6', email='user_6@domain.com', is_active=True, is_staff=True)
user.set_password(user.username)
user.save()
group = Group.objects.create(name=self.GROUPNAME_6)
group.user_set.add(user)
group.save()
def _setup_permviewbug(self):
"""
Setup group_6_ACCESS_PAGE view restriction
"""
page = Page.objects.get(title_set__title="page_6")
group = Group.objects.get(name__iexact=self.GROUPNAME_6)
PagePermission.objects.create(can_view=True, group=group, page=page, grant_on=ACCESS_PAGE_AND_CHILDREN)
PagePermission.objects.create(can_view=True, group=group, page=page, grant_on=ACCESS_PAGE_AND_DESCENDANTS)
def test_pageforbug(self):
all_pages = self._setup_pages()
self._setup_user()
self._setup_permviewbug()
for page in all_pages:
perm = PagePermission.objects.for_page(page=page)
# only page_6 has a permission assigned
if page.get_title() == 'page_6':
self.assertEquals(len(perm), 2)
else:
msg="Permission wrong at page %s" % (page.get_title())
self.assertEquals(len(perm), 0,msg)
granted = [ 'page_1',
'page_2',
'page_3',
'page_4',
'page_5',
]
# anonymous sees page_6 not
self.assertGrantedVisibility(all_pages, granted)
url = "/en/page_2/page_3/page_4/"
self.assertPageFound(url)
url = "/en/page_5/"
self.assertPageFound(url)
url = "/en/page_5/page_6/"
self.assertPageNotFound(url)
# group member
granted = [ 'page_1',
'page_2',
'page_3',
'page_4',
'page_5',
'page_6',
]
self.assertGrantedVisibility(all_pages, granted, username='user_6')
client = Client()
login_ok = client.login(username='user_6', password='user_6')
self.assertTrue(login_ok)
url = "/en/page_2/page_3/page_4/"
self.assertPageFound(url, client)
url = "/en/page_5/page_6/"
self.assertPageFound(url, client)