Skip to content

Commit

Permalink
Revert "Increase angle_end2end_tests batch timeout on Win7 NVIDIA"
Browse files Browse the repository at this point in the history
This reverts commit a8e2d2c.

Reason for revert: performance regression fixed in
KhronosGroup/Vulkan-ValidationLayers#3452,
rolled into Chromium in crrev.com/934959.

Original change's description:
> Increase angle_end2end_tests batch timeout on Win7 NVIDIA
>
> To unblock rolling VVL into Chromium,
> which have a performance regression on this platform.
>
> Bug: 1249209
> Change-Id: Ic66a1309b0482c41d8057bfea13303f2a306923d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3227076
> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#932483}

Bug: 1249209
Change-Id: I80c579110027037a786ca863de423c3628c45fc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3246093
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#935243}
  • Loading branch information
y-novikov authored and Chromium LUCI CQ committed Oct 27, 2021
1 parent f884a26 commit 97445d4
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 24 deletions.
3 changes: 1 addition & 2 deletions testing/buildbot/chromium.angle.json
Original file line number Diff line number Diff line change
Expand Up @@ -3411,8 +3411,7 @@
"args": [
"angle_end2end_tests",
"--gtest_filter=-*Vulkan_SwiftShader*",
"--bot-mode",
"--batch-timeout=600"
"--bot-mode"
],
"merge": {
"args": [],
Expand Down
6 changes: 2 additions & 4 deletions testing/buildbot/chromium.gpu.fyi.json
Original file line number Diff line number Diff line change
Expand Up @@ -37196,8 +37196,7 @@
"args": [
"angle_end2end_tests",
"--gtest_filter=-*Vulkan_SwiftShader*",
"--bot-mode",
"--batch-timeout=600"
"--bot-mode"
],
"merge": {
"args": [],
Expand Down Expand Up @@ -38013,8 +38012,7 @@
"args": [
"angle_end2end_tests",
"--gtest_filter=-*Vulkan_SwiftShader*",
"--bot-mode",
"--batch-timeout=600"
"--bot-mode"
],
"merge": {
"args": [],
Expand Down
18 changes: 0 additions & 18 deletions testing/buildbot/test_suite_exceptions.pyl
Original file line number Diff line number Diff line change
Expand Up @@ -94,29 +94,11 @@
'--max-processes=1',
],
},
# TODO(crbug.com/1249209) Remove when VVL performance is fixed
'Win7 FYI Release (NVIDIA)': {
'args': [
'--batch-timeout=600',
],
},
# TODO(crbug.com/1249209) Remove when VVL performance is fixed
'Win7 FYI x64 Release (NVIDIA)': {
'args': [
'--batch-timeout=600',
],
},
'win10-angle-x64-intel': {
'args': [
'--max-processes=1',
],
},
# TODO(crbug.com/1249209) Remove when VVL performance is fixed
'win7-angle-x64-nvidia': {
'args': [
'--batch-timeout=600',
],
},
},
'replacements': {
'Linux FYI Release (AMD RX 5500 XT)': {
Expand Down

0 comments on commit 97445d4

Please sign in to comment.