Daily Merge #17
Merged
Daily Merge #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The final CL for making software-backed keys work was landed in M97 (https://crrev.com/c/3173358) so the nodoc label for the new softwareBackedSubtleCrypto object should also be removed in M97. Bug: b:204182278 Change-Id: I7a65bd75b63fc107b07175f60362137e5e565c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245256 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Maria Petrisor <mpetrisor@chromium.org> Cr-Commit-Position: refs/heads/main@{#935334}
We should ignore invalid camera info and not add the camera into the camera list. Bug: b:201017507 Test: Manually trigger invalid GetCameraInfo results and make sure Chrome does not crash. Change-Id: I471e3528db67c17a8a4e3603b10176b9f5a579c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245755 Reviewed-by: Wei Lee <wtlee@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/main@{#935335}
Enabling lacros-primary will enable web-apps-crosapi functionality, so any Ash desktop PWA test relying on web-apps-crosapi being disabled needs to also disable lacros-primary. Bug: 1261978 Change-Id: I131a3d0ceeaf19f47ada56ca9510c1d601cd26de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3246692 Reviewed-by: Glen Robertson <glenrob@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/main@{#935336}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/786f6d4dff85..2ab6cbbb094f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yutak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yutak@google.com Change-Id: I72a4c56f4c237b307d23a0c0e575779d1a40b25e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3246511 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#935337}
R=chrishtr@chromium.org Change-Id: I1fd612442453129bab80579d3dc76395dd68de64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3158023 Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/main@{#935338}
Roll Chrome Win64 PGO profile from chrome-win64-main-1635303461-21bbf273b80cdb2dfee3360ea34b307bb797f286.profdata to chrome-win64-main-1635314384-e16f662e82e196cb7549a9fc68727b712a0e7571.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I95c6dab9ebf0e535226767dd10e98dd9b0e7f3be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3246861 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#935339}
It seems that this specific test fails because a bool variable wasn't initialized. Bug: 1097708 Test: unit_tests --gtest_filter="*WebKioskAppLauncherTest* Change-Id: I7fe8fcd48c983b52520a05f0bc7c02a5a7b0e0ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245395 Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by: Glen Robertson <glenrob@chromium.org> Commit-Queue: Ben Franz <bfranz@chromium.org> Cr-Commit-Position: refs/heads/main@{#935340}
Roll Chrome Win32 PGO profile from chrome-win32-main-1635303461-be94ea9d55f2f0905f73bb1cec34c8f7d8067ae9.profdata to chrome-win32-main-1635314384-f8d5080ce1710308158715e334cbb5b21c5fc457.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I107bcf11d8042548f4f867e2f7faab051012c145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245454 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#935341}
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/480c91d40b45..45a7f406aba6 2021-10-27 vapier@chromium.org ensure_bootstrap: bootstrap tools in parallel 2021-10-27 vapier@chromium.org pylint-1.6: drop unused version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,gavinmak@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,gavinmak@google.com,sokcevic@google.com Change-Id: Ieb5ec774f8d41a1ff20890a713f18a8686199fb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3246164 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#935342}
Currently kContentArea source is used for the following cases: (1) Automatically triggered re-authetication dialog. (2) Account addition dialog launched by the user from OGB. Add a new enum value for case 2 to improve UMA stats. Bug: 1261815 Change-Id: I91fe9ecc2acece96468cb4cd93086296c31e5423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245391 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/main@{#935343}
Replaced Callback<Void> with Runnable. Bug: 1229655 Change-Id: I7fb75e6c13b8dafe8033c8228ad6fc3545277c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3246933 Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/main@{#935344}
BUG=chromium:1263416 Change-Id: I7b12895ea3e2a512ad244d057b900fa9cbe1cfdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3244085 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/main@{#935345}
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Id7b1c395a9dc2cd42d48fc1b6a4ae5b3e804e7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3246916 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#935346}
Roll Chrome Linux PGO profile from chrome-linux-main-1635292756-6d7e179895ebddb35232646f0201bddd6374d319.profdata to chrome-linux-main-1635314384-742eb69bb155d4b3c45b7dcf920796f61a109a4d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1787db24904c93d1c7169259c10aad1db10c861d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3246661 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#935347}
As described in https://crrev.com/c/3217883, a performance regression was introduced by http://crrev.com/878400 and could be addressed by falling back on the DOM node's parent node when computing a parent for an element which is no longer in the flat tree. The underlying problem is that we are attempting to fire children- changed accessibility events on <slot> instances which are no longer in the flat tree. In order to do so we attempt to (re)create the ancestry, ultimately failing because we reach the node which is not in the flat tree. This attempt is made for each <slot> descendant whose subtree was removed from the shadow tree but remains in the DOM tree. The reason falling back on the DOM node's parent seems to solve the problem is that we cache that parent and stop attempting to compute it for each <slot>. However, we should not be firing those children-changed accessibility events in the first place. Bug: 1240686 Change-Id: I96c1f80abfd69064165c9474d711de2e05f2e492 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3237246 Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/main@{#935348}
In the previous implementation, if ping or pong frames were sent between
text frame and continuation frame, the WebSocket encoder didn't handle
the fragmented message correctly (e.g. text -> ping -> continuation,
text -> continuation -> pong -> continuation)
In this case, the parts of the message before the ping or pong frames
were lost, so only the following parts were passed to the
HttpServer::Delegate.
To solve this problem, this CL switches the method of processing
messages in WebSocketEncoder::DecodeFrame() based on the type of
frame. For text and continuation frames, the message is buffered until
the end of the message, and no longer cleared if ping or pong frames
are received. On the other hand, for ping frames, the contents are
passed back directly and not buffered.
To check this implementation works correctly, add tests which send text
or ping frames in various orders.
This is a copy of
https://chromium-review.googlesource.com/c/chromium/src/+/3209721 by
Shiho Noda.
Bug: 1226710
Change-Id: I4ec52e72866e2ce534d654233babc0e07d886622
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3220895
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/main@{#935349}
This reverts commit b7d510c. Reason for revert: speculative revert for new flakiness in PageLoadMetricsBrowserTestWithAnimatedLCPFlag, see first failing build https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/99853 Original change's description: > [LCP] Add animated image support > > This CL adds support for better handling of animated images in LCP: > * A new attribute is exposing the first animated frame's paint time > (behind a flag). > * `startTime` is not changed. > * The PageLoadMetrics reported for LCP are set to that first frame paint > time for animated images (behind another flag). > * Entries are not emitted until the image is loaded. > > Relevant spec issue: > w3c/largest-contentful-paint#83 > > Change-Id: I6bb01eacb4f200f9c032ffcfcd9a1a41126a7773 > Bug: 1260953 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226157 > Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> > Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> > Cr-Commit-Position: refs/heads/main@{#935133} Bug: 1260953 Change-Id: I00878689de95de38645195da81c6baf577d868a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3247071 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Owners-Override: Mikel Astiz <mastiz@google.com> Cr-Commit-Position: refs/heads/main@{#935350}
…air and transport BUG=webrtc:10568,webrtc:10569 Change-Id: I130e05faa87b6367fcaa3ab593a637c1286f86c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3247070 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/main@{#935351}
Multiple content settings providers use ContentSettingsType::DEFAULT to indicate that any setting might have changes. Many observers don't handle this case correctly. We added a wrapper class for ContentSettingsType that enforces correctly checking whether the type an observer cares about is affected. Bug: 1245927 Change-Id: Ic10b1dc266ca8790fcc3bf06128b33ec6462e919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3244088 Reviewed-by: David Bertoni <dbertoni@chromium.org> Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/main@{#935352}
This makes menus etc. in incognito Windows properly dark. Bug: 1262961 Change-Id: I715930619335a5aee2fedc55298fd16b87893a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3242323 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/main@{#935353}
It looks like the tests from ProfileMenuClickTest* can pass now. Re-enable them on Lacros bots. _SigninDisallowed tests aren't enabled yet because we force kSigninAllowed to be true on Lacros Fixed: 1170605 Change-Id: I55a0947a13d8445fa47ea2d94a471ff405a4e01e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245091 Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/main@{#935354}
…est" This reverts commit 045af32. Reason for revert: suspecting of causing test breakages for OobeTestApiTest.OobeAPI, see first failing build https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/18264 Original change's description: > OOBE: Remove WebContentsLoadFinishedWaiter from EULA browsertest > > While EULA webview is loading, we show loading step, so, instead of > using WebContentsLoadFinishedWaiter in EULA browsertest, we can simply > wait for 'eula' loaded step. > > In offline EULA, we should only proceed to 'eula' loaded step when > the timeout for loading the online EULA is finished. > > Bug: 1263051 > Change-Id: I878bbe087adf88ad9d6a86cf209ddf4f70d4d576 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3242023 > Commit-Queue: Ossama Mahmoud <osamafathy@google.com> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/main@{#934906} Bug: 1263051 Change-Id: I0c3613abe1ac5d05cc4fa2cb14fe33f981dc54a9 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3247171 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mikel Astiz <mastiz@google.com> Cr-Commit-Position: refs/heads/main@{#935355}
https://chromium.googlesource.com/angle/angle.git/+log/421dbf200d36..6e832bfe26ae 2021-10-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from b7a27dd to 6e4379b (441 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I768af5f0817b972fa2fb31b5d2e8c3c4d35ee597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3246761 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#935356}
Adding a pref to enable/disable the feature is the first step towards giving users access to it. This CL adds the pref and updates the UI logic to respect it. This leaves the code in a slightly non-idiomatic state: the HPS notify _view_ (vs controller, which doesn't yet exist) registers preferences for the feature. The way to fix this is, IIUC: - Create a controller class that owns + provides access to an instance of the view. - Have UnifiedSystemTray own an instance of the controller and use it to access the view. My next CL will make this refactor. I've kept the two changes separate so that the view logic review isn't intertwined with the refactor review. Note that the new preference uses our clarified naming, but that older code (e.g. instance variable names) isn't touched. This will be addressed in a series of forthcoming CLs that rename the classes etc. Change-Id: I23bcdac192018d8e988bb90018f1a6ba085c9dfe Bug: chromium:1241704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3216779 Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Tony Yeoman <tby@chromium.org> Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/main@{#935357}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: I6a50964dce03ae92384795fd6b4037e3924c6b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3246401 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#935358}
Note that the old method is already returning the PrimaryFrameTree so this patch is just about making that explicit. Trivial change that renames all test files leaving the production code for a later patch. That code will need a closer look to make sure that call sites are really expecting the primary frame tree (note they are already getting the primary frame tree, so this is just an extra check for peace of mind). Keeping the old method around for a while will also prevent this massive patch from being reverted if an optional try-bot later fails. Bug: 1251094 Change-Id: Ibc86aedf203013e41e61ede94e6af929f80ee477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3231330 Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Sreeja Kamishetty <sreejakshetty@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/main@{#935359}
This splits the before shared list of profiles for contacts and addresses into two lists. This way we can decide what to show for each of the lists independently. Bug: b/181538193 Change-Id: I3aea643820ca102d620817197c041deb2de57315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3240951 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/main@{#935360}
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fabb677a..e93fe1e8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel R=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3e2c00850214d339cb116f478453b2644492d196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245569 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#935361}
This removes the chrome://appcache-internals url. The code that backs this will be removed in a followup. Bug: 582750 Change-Id: I22295032dd461944451c085cb81101d02866f2e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3246056 Auto-Submit: enne <enne@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by: Samuel Huang <huangs@chromium.org> Reviewed-by: Camille Lamy <clamy@chromium.org> Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/main@{#935362}
This CL also adds a new method to force-install extensions in the ExtensionForceInstallMixin via LocalPolicyTestServerMixin and UserPolicyBuilder objects. The already existing methods don't make it possible to force-install extensions in MGS. Bug: b:202150852 Change-Id: I7703e08de888f6554d2d7ecdd2eb9e3c5d094cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226159 Commit-Queue: Maria Petrisor <mpetrisor@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/main@{#935363}
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e93fe1e8..91620f53 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel R=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8fe9e0e74f88217cc1b5890371e0ac37a9de2d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3247330 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#935386}
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/a2f52e1177..f70eadadd7 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/a2f52e1177..f70eadadd7 No .def changes Bug: None Change-Id: Ifbfeef4bb955d759f25af7b8152e7c8a3541e8a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3247350 Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Auto-Submit: Danil Chapovalov <danilchap@chromium.org> Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/main@{#935387}
Bug: 1262171 Change-Id: I2e4d6fa58767fabe8ecedaa6c700b6a949f8698c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245792 Auto-Submit: Sam Maier <smaier@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/main@{#935388}
https://webrtc.googlesource.com/src.git/+log/519c15de2b86..af09c1309652 2021-10-27 mbonadei@webrtc.org Fix -Wunused-but-set-variable. 2021-10-27 thakis@chromium.org Run clang update script under python3 in webrtc DEPS file 2021-10-26 sprang@webrtc.org Add ability to control TaskQueuePacedSender holdback window. 2021-10-26 boivie@webrtc.org dcsctp: Remove debug-log-only TSN collection 2021-10-26 ilnik@webrtc.org Remove unused IXXXBuffer::PasteFrom If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1261812 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3de1ede142817381a18739f4303368483f6c822a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3246544 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#935389}
The Crostini installation displays the following messages (in order): - Starting the Linux container - Setting up the Linux container - Starting the Linux container This CL updates the first of these (the create container step) to match the second. Bug: 1015722 Change-Id: I42ca621f67dffb90a3d6b59247bf0e689ac1e7d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3244709 Auto-Submit: Timothy Loh <timloh@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/main@{#935390}
Release_Notes: http://go/projector_app-x20/relnotes/Main/projector_app_nightly_202110270100_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/projector_app/app/+/ZXIcQJhEIO97vrK-zObnZPkmSXnXLXsuZmY1p5A_rDUC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/projector-app-chromium-autoroll Please CC cros-projector-oncall@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome Bug: b/200293105,b/200960615,b/203818777 Tbr: cros-projector-oncall@grotations.appspotmail.com Change-Id: I90e5a1a1cfb106d5d28e80f4075ff2a954b7f21c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3246660 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#935391}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/11ed8452a916..7ee0559917da 2021-10-27 dsv@chromium.org Add JS code for websocket throttling browser test. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:423246 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I384b2e61973e0dbb7c93d83b10df4e40d3cdc6bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3246409 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#935392}
crbug/1235878 seems to indicate that the test binaries are not starting correctly. This CL adds logging to test_env.py to print the return code of the binary to help debug what might be failing. Bug: 1235878 Change-Id: Ia1dd6c05d7b6563d8c124df9cc3a68de34bd623d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245566 Reviewed-by: Dirk Pranke <dpranke@google.com> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/main@{#935393}
This reverts commit d881c38. Reason for revert: suspect of breaking deterministic builds. Bug: 1263979 Original change's description: > Roll Fuchsia SDK from 6.20211026.2.1 to 6.20211026.3.1 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll > Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast > Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com > Disable-Retries: true > Change-Id: I38cce74e11e1be5cf583056f003930800599ba9e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3246359 > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#935293} Change-Id: I06afcc3d990a79f2a67a93f8a1e362fd79e33070 Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3247197 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mikel Astiz <mastiz@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/main@{#935394}
Bug: 1152397 Change-Id: I1a20bcb6b3b69a4d1fe41aa9d5e54789dc3a5a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245770 Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/main@{#935395}
On Windows, some of PartitionAlloc's OOM crashes are due to commit failure, as the total system-wide commit charge is limited. On this platform, decommit all empty slot spans, then retry in case of failure. This will not necessarily solve the problem, since a process which is close to crashing due to memory issues may crash soon thereafter anyway, but since total empty but committed memory can reach >10%, this may still help, particularly for cases where there is a shift in allocation patterns. Bug: 998048 Change-Id: Iae606a9822c19e3e89f9f7bd9d9378947811cdb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3241288 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/main@{#935396}
Appending elements to the top layer works for container queries and we handle ::backdrop pseudo element insertions by not skipping style recalc for ::backdrop for top layer elements. Adding a DCHECK to warn us that we may need to revisit top layer for container queries if that changes in the future. Also added a test for nested dialogs. Bug: 1259707 Change-Id: I03cf360391eece103c3c20c80cd34f4466eb42c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3247132 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#935397}
Animation::Create can throw and exception or return nullptr. This method is called from AnimationTimeline::Play, which was implicitly asserting that no exception is thrown and checks that the animation was created. These assumptions resulted in a crash when the effect timing options contain unsupported values. Bug: 1245487 Change-Id: I39afd196c9881754ebed5f1d7c4d37027c2ec147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245202 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#935398}
Bug: 1242380 Change-Id: I9346b3432585bff7c62c15f4b4e748c15c126862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3244932 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#935399}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/109cd672f04f..fab82b09dd7f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mastiz@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mastiz@google.com Change-Id: I26bf523ef6e8e055b17765b298793ff4fb950346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3247212 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#935400}
Demo was useful early on but now we're shipping Chrome on Vulkan and it is no longer necessary, Change-Id: I8fe2b80bb8051a4eb029089097019c82cb4add21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245972 Reviewed-by: Peng Huang <penghuang@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/main@{#935401}
Bug: fuchsia:60820 Change-Id: Ia59759f2d265b54b5fd4118eeea97b612d5daa23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245957 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/main@{#935402}
This adds a step to loading icons for crostini apps of applying a colored dot in the same place other badges go. The default color is "transparent" so this is currently a no-op, but you can see what it will be like by changing the default value in crostini_util.cc. Settings UI will come in a follow-up CL. Bug: 1261319 Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome Change-Id: I4e19ba1be915ec7516c50f8111ed7415e2cbb2cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3233700 Commit-Queue: Fergus Dall <sidereal@google.com> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Auto-Submit: Fergus Dall <sidereal@google.com> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Nancy Wang <nancylingwang@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/main@{#935403}
Bug: 1058430 Change-Id: I5bad990451331826ffd18b6373e36933f01272c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245812 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/main@{#935404}
https://chromium.googlesource.com/angle/angle.git/+log/6e832bfe26ae..bc09d119479d 2021-10-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 21810915c4f1 to d143249a93bc (1 revision) 2021-10-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 06cd4429bf9e to e706a029a256 (10 revisions) 2021-10-27 thakis@chromium.org Run clang update script under python3 in angle 2021-10-27 ajgo@chromium.org disable cfguards for all deqp tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1261812 Tbr: timvp@google.com Test: Test: CQ plus above Change-Id: Ie8f96f406161b309acdc9fe41dac6e0470518884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3247570 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#935405}
Update the comment in scoped_keep_alive.h to mention that ScopedProfileKeepAlive exists, for discoverability. Add a comment in scoped_profile_keep_alive.h to explain its subtleties, and also point to ScopedProfileKeepAlive for discoverability. Change-Id: Idae4d62e2d17445d4954d3621c59454c90fcfdb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245815 Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/main@{#935406}
Roll Chrome Mac PGO profile from chrome-mac-main-1635314384-7362b0ba73b40c1f78af386b6503b8ba7f1443c7.profdata to chrome-mac-main-1635335251-299a233e4dc6dd8e28eb3dc6e5b880f90beaadff.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5c39acf0c2149c57455e9ba0db9f7b76efbdb1ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3247574 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#935407}
Also migrates progress-list-item as demo setup screen is the only component that depends on it Bug: 1251576 Change-Id: I51a774a22743cc635e6e7a10b4079c01fa06af5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3244094 Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by: Renato Silva <rrsilva@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/main@{#935408}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7ee0559917da..b1733e82bcf8 2021-10-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2463859bdbc16ebbf87ae4640ab01c101f445f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3247213 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#935409}
Roll Chrome Linux PGO profile from chrome-linux-main-1635314384-742eb69bb155d4b3c45b7dcf920796f61a109a4d.profdata to chrome-linux-main-1635335251-99f26b96d1d00ea88c8e462f5c82e2ac6f5ad9eb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic836767737c5c086a1e24a64d249305a95358ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3247670 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#935410}
ng_link.h included ng_physical_fragment.h, and ng_physical_fragment.h included ng_link.h. Forward-declare NGPhysicalFragment in ng_link.h instead. Change-Id: I5dd659ba4dc8efc86db5f75900a3fa30d936b333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3247152 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#935411}
If a block is empty, it will usually fit inside one fragmentainer. But not always. If there's tall borders/padding, for instance, we might split the block into fragments. Never attempt to stretch the intrinsic block-size of a fragment unless we're working on the first one, or else we might end up creating an infinite number of them. Bug: 1261747 Change-Id: Ic9bc5c08259d39b39e3c7a5b6a49b197d1dd115a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245260 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#935412}
See: https://skia-review.googlesource.com/c/skia/+/463799 Bug: skia:11942 Change-Id: I37add27397c825310dab1fac7bb8a504e1afa6bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245891 Auto-Submit: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/main@{#935413}
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/e90569de09a9..7424791d0865 2021-10-27 junyer@google.com Fix another latent bug in Regexp::Walker<T>::Reset(). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/re2-chromium Please CC thakis@chromium.org,junyer@chromium.org on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: thakis@chromium.org,junyer@chromium.org Change-Id: I4637c6a6281a49af21a745d1ae1704f634fa4b91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3247572 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#935414}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.