-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/avatar upload #166
Feature/avatar upload #166
Conversation
What is your opinion about storing the avatar as base64encoded string in the database? I'm using multi-server deployments, so persisting user uploads in 1 directory on 1 server will cause issues. Several deployment tools also create a new checkout in a separate directory, which will cause the avatars to break. I can work around these issues by making the avatar upload directory a shared NFS share or use a shared object store... Storing the image in the database seems like the easiest solution, but it may cause performance issues and increase database disk usage/load. @Schnoop |
Yeah - that would be a good option. If the database should get in trouble at some point in the future it should not be a problem to move the images back to files and think about other deployment options. Maybe a S3 storage is another option to store the user generated images. |
Changed implementation to store image in database. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this merge request! I left some review notes :)
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #166 +/- ##
===========================================
- Coverage 0.08% 0.08% -0.01%
- Complexity 1831 1845 +14
===========================================
Files 179 181 +2
Lines 6140 6220 +80
===========================================
Hits 5 5
- Misses 6135 6215 +80
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
#8