Introduction of concepts for next-generation call resolving #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxisto
force-pushed
the
next-gen-call-resolver
branch
from
adf271c
to
695537e
Compare
oxisto
changed the title
oxisto
changed the title
oxisto
force-pushed
the
next-gen-call-resolver
branch
from
7cbda07
to
375dc20
Compare
KuechA
reviewed
Apr 4, 2024
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/ScopeManager.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/ScopeManager.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/Language.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/Language.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/Language.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/Language.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/graph/declarations/FunctionDeclaration.kt
Outdated
Show resolved
Hide resolved
cpg-language-cxx/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/cxx/CLanguage.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/passes/SymbolResolver.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/passes/SymbolResolver.kt
Show resolved
Hide resolved
oxisto
force-pushed
the
next-gen-call-resolver
branch
from
409c8a1
to
2d569fd
Compare
|
Did you check if this PR fixes #1045? |
oxisto
force-pushed
the
next-gen-call-resolver
branch
from
3214f4e
to
ba50ede
Compare
KuechA
approved these changes
Apr 5, 2024
oxisto
force-pushed
the
next-gen-call-resolver
branch
from
2863c40
to
079e781
Compare
After #1484, this now also fixes #1045, at least for the case where the stdlib is included. Otherwise we cannot know that |
|
@KuechA I will wait until next week to merge this after @maximiliankaul and @konradweiss are back for some more discussions. It is important to get the concepts correct this time. |
oxisto
force-pushed
the
next-gen-call-resolver
branch
from
4c965f5
to
0458666
Compare
konradweiss
requested changes
Apr 11, 2024
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/ScopeManager.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/passes/SymbolResolver.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/passes/SymbolResolver.kt
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/passes/SymbolResolver.kt
Outdated
Show resolved
Hide resolved
oxisto
force-pushed
the
next-gen-call-resolver
branch
from
806fdc2
to
5bfbdd0
Compare
|
konradweiss
approved these changes
Apr 12, 2024
oxisto
added a commit
that referenced
this pull request
Apr 12, 2024
This should have been part of #1496 but I forgot to clean this up.
oxisto
added a commit
that referenced
this pull request
Apr 13, 2024
This should have been part of #1496 but I forgot to clean this up.
oxisto
added a commit
that referenced
this pull request
Apr 13, 2024
This should have been part of #1496 but I forgot to clean this up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to implement the initial concepts described in #704 and also migrates the resolving of regular function calls to the new system.
Fixes #406
Fixes #1498
Fixes #1497