Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using node builder functions for Go language frontend #968

Merged
merged 5 commits into from Nov 22, 2022
Merged

Using node builder functions for Go language frontend #968

merged 5 commits into from Nov 22, 2022

Conversation

oxisto
Copy link
Member

@oxisto oxisto commented Nov 10, 2022 •
edited

  • Declaration builder
  • Expression builder
  • Statement builder

@oxisto oxisto added the go label Nov 10, 2022
@oxisto oxisto mentioned this pull request Nov 10, 2022
Merged
8 tasks
@oxisto oxisto force-pushed the use-node-builder-in-go branch 3 times, most recently from 40134d3 to decaba7 Compare November 22, 2022 10:13
@oxisto oxisto marked this pull request as ready for review November 22, 2022 10:47
@oxisto oxisto mentioned this pull request Nov 22, 2022
Merged
@oxisto oxisto force-pushed the use-node-builder-in-go branch 2 times, most recently from 236ed04 to dbce662 Compare November 22, 2022 12:50
@oxisto oxisto mentioned this pull request Nov 22, 2022
Closed
KuechA
KuechA reviewed Nov 22, 2022
View reviewed changes
Copy link
Contributor

@KuechA KuechA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have preferred it without the changes to the Builders to avoid conflicts with #963 but since it seems to affect only few locations, it should be ok.

@oxisto oxisto enabled auto-merge (squash) November 22, 2022 16:29
@sonarcloud
Copy link

sonarcloud bot commented Nov 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

27.3% 27.3% Coverage
0.0% 0.0% Duplication

@oxisto oxisto merged commit f436359 into main Nov 22, 2022
@oxisto oxisto deleted the use-node-builder-in-go branch November 22, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KuechA KuechA KuechA approved these changes

@maximiliankaul maximiliankaul Awaiting requested review from maximiliankaul maximiliankaul is a code owner

@konradweiss konradweiss Awaiting requested review from konradweiss konradweiss is a code owner

Assignees
No one assigned
Labels
go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oxisto @KuechA