Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump slf4j.version from 1.7.36 to 2.0.0 #181

Merged
merged 1 commit into from Aug 25, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 22, 2022

Bumps slf4j.version from 1.7.36 to 2.0.0.
Updates slf4j-api from 1.7.36 to 2.0.0

Commits
  • 0614d46 prepare release 2.0.0
  • b1afcd0 javadoc edits
  • 20cd3ad start work on 2.0.0-SNAPSHOT
  • aeebb61 prepare release 2.0.0-beta1
  • 1068cd0 javadoc changes
  • 4e4e56a add CheckReturnValue annotation in org.slf4j.helpers
  • 0dcfa19 check for return value in some oggingEventBuilder methods
  • e7ca8d1 start work on 2.0.0-beta1-SNAPSHOPT
  • 2314de9 add setMessage and log method to the fluent API
  • 508a796 set version to 2.0.0-beta0
  • Additional commits viewable in compare view

Updates slf4j-simple from 1.7.36 to 2.0.0

Commits
  • 0614d46 prepare release 2.0.0
  • b1afcd0 javadoc edits
  • 20cd3ad start work on 2.0.0-SNAPSHOT
  • aeebb61 prepare release 2.0.0-beta1
  • 1068cd0 javadoc changes
  • 4e4e56a add CheckReturnValue annotation in org.slf4j.helpers
  • 0dcfa19 check for return value in some oggingEventBuilder methods
  • e7ca8d1 start work on 2.0.0-beta1-SNAPSHOPT
  • 2314de9 add setMessage and log method to the fluent API
  • 508a796 set version to 2.0.0-beta0
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Aug 22, 2022
@mjacoby mjacoby marked this pull request as draft August 24, 2022 07:35
@mjacoby
Copy link
Member

mjacoby commented Aug 24, 2022

Updating slf4j to 2.0.0 requires updating logback to 1.3.x. However, there is no stable 1.3.x release of logback. Currently, this PR uses 1.3.0-beta0 and works.

However, this PR is on hold until a stable release of logback 1.3.x is available.

@mjacoby
Copy link
Member

mjacoby commented Aug 24, 2022

After using dedicated library in unit tests to access log messages slf4j can be updated without requiring logback update.

@mjacoby
Copy link
Member

mjacoby commented Aug 25, 2022

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/maven/slf4j.version-2.0.0 branch from 2cff12f to dd2f371 Compare August 25, 2022 12:02
Bumps `slf4j.version` from 1.7.36 to 2.0.0.

Updates `slf4j-api` from 1.7.36 to 2.0.0
- [Release notes](https://github.com/qos-ch/slf4j/releases)
- [Commits](qos-ch/slf4j@v_1.7.36...v_2.0.0)

Updates `slf4j-simple` from 1.7.36 to 2.0.0
- [Release notes](https://github.com/qos-ch/slf4j/releases)
- [Commits](qos-ch/slf4j@v_1.7.36...v_2.0.0)

---
updated-dependencies:
- dependency-name: org.slf4j:slf4j-api
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: org.slf4j:slf4j-simple
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/maven/slf4j.version-2.0.0 branch from dd2f371 to c491b02 Compare August 25, 2022 14:22
@mjacoby
Copy link
Member

mjacoby commented Aug 25, 2022

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 25, 2022

Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mjacoby mjacoby marked this pull request as ready for review August 25, 2022 14:41
@mjacoby mjacoby merged commit cb726ad into main Aug 25, 2022
@mjacoby mjacoby deleted the dependabot/maven/slf4j.version-2.0.0 branch August 25, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant