Skip to content
This repository has been archived by the owner on Feb 22, 2021. It is now read-only.

About Section #43

Closed
supportreq opened this issue Oct 30, 2013 · 12 comments
Closed

About Section #43

supportreq opened this issue Oct 30, 2013 · 12 comments

Comments

@supportreq
Copy link

Hi HoloAddict,

This super app requires an about us section, which will talk about your contribution towards the app.

It can be a like the GMail "|" button

@FredJul
Copy link
Owner

FredJul commented Nov 14, 2013

You're right, this is something I should add so I accept this request, at least to thanks the translators and contributors. Nevertheless I seriously lack of free times currently, I won't be able to do it soon.

@strubul
Copy link

strubul commented Jan 15, 2014

Hi HoloAddict,
I would like to contribute and I was trying to add the button about at the Bar. But I think I met some issues with the title...

The main issue is that a big custom title such as "Times - World" gets truncated in the currently published version. And maybe this is a problem if you have multiple prefixes starting with "Times". For example:

default

I tried to add an about button but then the main title "Entries" gets truncated:

aboutbutton

One way to fix this is to split the bar when there is no much space and place them at the bottom:

splitnarrow

What is your opinion on these? If you have a short "about" text I would be able to make a pull request!

@FredJul
Copy link
Owner

FredJul commented Jan 16, 2014

Hi!

In fact I don't really want to split the action bar due to the drawer. When you open the navigation drawer, you expect the option to be visible into the top action bar. If you look well, even Google do not use much the splited action bar...

And I also do not want to add more than 3 items into the action bar, due to the lack of place. I think a good solution would be to put a "about us" link into the settings screen. It's a bit hidden but this is not a important UI part and Google is also doing this into android settings.

Of course I would be happy to include your work ;) I will send an email to all people which participate to put their name/nickname/email or what they want in it.

@FredJul
Copy link
Owner

FredJul commented Jan 16, 2014

Or maybe hide the refresh button (I think it's the less used one due to the automatic update) and add the menu overflow with options inside like "refresh", "edit feeds", "about us" and "parameters".

In fact I think some people won't like the disappearance of the refresh button but it may be the best solution. Some people also told me that the "edit feeds" option is hard to find, this would solve this issue in the same time.

@strubul
Copy link

strubul commented Jan 16, 2014

Yeap I think you are right..Maybe something like that (though I am not sure about the appropriate icons):

overflow

@ildar
Copy link

ildar commented Jan 17, 2014

16.01.2014 7:54 ÐÏÌØÚÏ×ÁÔÅÌØ "HoloAddict" notifications@github.com
ÎÁÐÉÓÁÌ:

Or maybe hide the refresh button (I think it's the less used one due to
the automatic update) and add the menu overflow with options inside like
"refresh", "edit feeds", "about us" and "parameters".

Actually the FeedEx UI is balanced quite well except...

Some people also told me that the "edit feeds" option is hard to find,
this would solve this issue in the same time.
True.
Please change carefully. Thanks!

@FredJul
Copy link
Owner

FredJul commented Jan 17, 2014

I found the screenshot quite nice ;) In fact I think you're right. It's better to hide the "mark all as read" button to avoid to click on it accidentally, even if I use it more than the refresh button.

Are you agree with that ildar?

@ildar
Copy link

ildar commented Jan 18, 2014

Double yes! ;-)

@mhuhtala
Copy link
Contributor

mhuhtala commented Feb 9, 2014

I actually use the 'refresh' button all the time, and I, too, initially had trouble finding the 'edit feeds' button, so I think the layout in strubul's picture is an improvement. Also, when viewing the entries of one single feed, there 'edit' menu option could be present and it could take the user to edit that feed's settings directly. I can take a stab at implementing this.

@mhuhtala
Copy link
Contributor

I implemented a simple 'about' screen and put the option to open it as the first thing in the settings (GeneralPrefsActivity). The 'about' activity currently shows the programmatically fetched version number (versionName) of the app, a copyright notice and some license information. There's a TextView for listing the volunteer contributors. I left it as a placeholder for now.

The menus in the list views in my version are as follows:

Drawer:

  • hide read (ActionBar)
  • refresh (ActionBar)
  • edit feeds (overflow menu)
  • settings (overflow menu)

Entries list:

  • hide read (ActionBar)
  • refresh (ActionBar)
  • mark all as read (overflow menu)
  • edit feeds (overflow menu)
  • settings (overflow menu)

I made the label on the 'edit feeds' option say 'feeds' explicitly, instead of just edit. I thought it was a lot clearer that way. When viewing the entries of a single feed, the option changes to "edit feed" (singular) and it takes the user directly to edit the configuration of that feed, not the list of all feeds.

The 'starred' and 'search' views have no overflow menus at all and only two options each in the ActionBar (same as before).

@mhuhtala
Copy link
Contributor

Some screenshots (sorry about the size, I can't be asked to scale these).

Settings

About

Menu in entries list

@FredJul
Copy link
Owner

FredJul commented Feb 22, 2014

This is merged so I mark it as closed (even if I need to add all the contributors names)

@FredJul FredJul closed this as completed Feb 22, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants