update react message (#188)

__tests__/integration/error-react-explicit/expected-output.txt

@@ -0,0 +1,8 @@
+- snowpack installing...
+⠼ snowpack installing... react-dom
+✖ Dependency "react-dom" has no native "module" entrypoint.
+  To continue, install our drop-in, ESM-ready builds of "react" & "react-dom" to your project:
+    npm: npm install react@npm:@pika/react react-dom@npm:@pika/react-dom
+    yarn: yarn add react@npm:@pika/react react-dom@npm:@pika/react-dom
+See https://www.snowpack.dev/#react for more info.
+⚠ Finished with warnings.

__tests__/integration/error-react-explicit/package.json

@@ -0,0 +1,13 @@
+{
+  "scripts": {
+    "TEST": "node ../../../pkg/dist-node/index.bin.js"
+  },
+  "snowpack": {
+    "webDependencies": [
+      "react-dom"
+    ]
+  },
+  "dependencies": {
+    "react-dom": "latest"
+  }
+}

__tests__/integration/error-react/expected-output.txt

@@ -0,0 +1,8 @@
+- snowpack installing...
+⠼ snowpack installing... react
+✖ Dependency "react" has no native "module" entrypoint.
+  To continue, install our drop-in, ESM-ready builds of "react" & "react-dom" to your project:
+    npm: npm install react@npm:@pika/react react-dom@npm:@pika/react-dom
+    yarn: yarn add react@npm:@pika/react react-dom@npm:@pika/react-dom
+See https://www.snowpack.dev/#react for more info.
+⚠ Finished with warnings.

__tests__/integration/error-react/package.json

@@ -0,0 +1,8 @@
+{
+  "scripts": {
+    "TEST": "node ../../../pkg/dist-node/index.bin.js"
+  },
+  "dependencies": {
+    "react": "latest"
+  }
+}

docs/08-guides.md

@@ -110,14 +110,14 @@ const html = htm.bind(h);
 import React, { useState } from '/web_modules/react.js';
 ```
 
-**Important:** React is [not yet published with ES Module support](https://github.com/facebook/react/issues/11503), and due to the way it's written, it's impossible to install as a dependency (*"Error: '__moduleExports' is not exported by node_modules/react/index.js"*). **However**, it is still possible to use React with Snowpack thanks to [@sdegutis](https://github.com/sdegutis)'s [@reactesm](https://www.npmjs.com/org/reactesm) project & npm/yarn's alias feature:
+**Important:** React is [not yet published with ES Module support](https://github.com/facebook/react/issues/11503), and the way that it's written makes it impossible to install as a dependency (*"Error: '__moduleExports' is not exported by node_modules/react/index.js"*). **However**, React is still supported thanks to our actively-maintained ESM builds of [React](https://www.npmjs.com/package/@pika/react) & [React-DOM](https://www.npmjs.com/package/@pika/react). You can install them both in your project under an alias like so:
 
 ```
 npm install react@npm:@reactesm/react react-dom@npm:@reactesm/react-dom
    yarn add react@npm:@reactesm/react react-dom@npm:@reactesm/react-dom
 ```
 
-When installed under the usual react/react-dom alias, Snowpack will install these easier-to-optimize ESM distributions into your `web_modules/` directory.
+When installed under the react/react-dom alias, all tooling (including Snowpack) will benefit from these easier-to-analyze ESM distributions of the popular packages.
 
 
 

src/index.ts

@@ -41,6 +41,7 @@ export interface InstallOptions {
   dedupe?: string[];
 }
 
+const ALWAYS_SHOW_ERRORS = new Set(['react', 'react-dom']);
 const cwd = process.cwd();
 const banner = chalk.bold(`snowpack`) + ` installing... `;
 const installResults = [];
@@ -117,15 +118,14 @@ function detectExports(filePath: string): string[] | undefined {
  */
 function resolveWebDependency(dep: string, isExplicit: boolean): DependencyLoc {
   // if dep includes a file extension, check that dep isn't a package before returning
+  const depManifestLoc = resolveFrom.silent(cwd, `${dep}/package.json`);
   if (path.extname(dep) && !resolveFrom.silent(cwd, `${dep}/package.json`)) {
     const isJSFile = ['.js', '.mjs', '.cjs'].includes(path.extname(dep));
     return {
       type: isJSFile ? 'JS' : 'ASSET',
       loc: resolveFrom(cwd, dep),
     };
   }
-
-  const depManifestLoc = resolveFrom.silent(cwd, `${dep}/package.json`);
   if (!depManifestLoc) {
     throw new ErrorWithHint(
       `"${dep}" not found. Have you installed the package via npm?`,
@@ -139,6 +139,19 @@ function resolveWebDependency(dep: string, isExplicit: boolean): DependencyLoc {
   if (!foundEntrypoint && isExplicit) {
     foundEntrypoint = depManifest.main || 'index.js';
   }
+  if (
+    (dep === 'react' || dep === 'react-dom') &&
+    (!foundEntrypoint || foundEntrypoint === 'index.js')
+  ) {
+    throw new ErrorWithHint(
+      chalk.bold(`Dependency "${dep}" has no native "module" entrypoint.`) +
+        `
+  To continue, install our drop-in, ESM-ready builds of "react" & "react-dom" to your project:
+    npm: npm install react@npm:@pika/react react-dom@npm:@pika/react-dom
+    yarn: yarn add react@npm:@pika/react react-dom@npm:@pika/react-dom`,
+      chalk.italic(`See ${chalk.underline('https://www.snowpack.dev/#react')} for more info.`),
+    );
+  }
   if (!foundEntrypoint) {
     throw new ErrorWithHint(
       `dependency "${dep}" has no native "module" entrypoint.`,
@@ -147,12 +160,6 @@ function resolveWebDependency(dep: string, isExplicit: boolean): DependencyLoc {
       ),
     );
   }
-  if (dep === 'react' && foundEntrypoint === 'index.js') {
-    throw new ErrorWithHint(
-      `dependency "react" has no native "module" entrypoint.`,
-      chalk.italic(`See: ${chalk.underline('https://github.com/pikapkg/web#a-note-on-react')}`),
-    );
-  }
   return {
     type: 'JS',
     loc: path.join(depManifestLoc, '..', foundEntrypoint),
@@ -224,7 +231,7 @@ export async function install(
     } catch (err) {
       installResults.push([installSpecifier, false]);
       spinner.text = banner + formatInstallResults(skipFailures);
-      if (skipFailures) {
+      if (skipFailures && !ALWAYS_SHOW_ERRORS.has(installSpecifier)) {
         continue;
       }
       // An error occurred! Log it.