cleanup hmr error logging

FredKSchott · Oct 2, 2020 · f2279c8 · f2279c8 · vercel · Oct 2, 2020
1 parent 6d8550b
commit f2279c8
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/snowpack/assets/hmr-client.js b/snowpack/assets/hmr-client.js
@@ -156,11 +156,11 @@ socket.addEventListener('message', ({data: _data}) => {
     return;
   }
   if (data.type === 'error') {
-    createNewErrorOverlay(data);
     console.error(
       `[ESM-HMR] ${data.fileLoc ? data.fileLoc + '\n' : ''}`,
       data.title + '\n' + data.errorMessage,
     );
+    createNewErrorOverlay(data);
     return;
   }
   if (data.type === 'update') {
@@ -174,7 +174,13 @@ socket.addEventListener('message', ({data: _data}) => {
         }
       })
       .catch((err) => {
-        console.error('update fail', err);
+        console.error('[ESM-HMR] Hot Update Error', err);
+        createNewErrorOverlay({
+          title: 'Hot Update Error',
+          fileLoc: data.url,
+          errorMessage: err.message,
+          errorStackTrace: err.stack,
+        });
       });
     return;
   }
@@ -189,10 +195,11 @@ window.addEventListener('error', function (event) {
   if (event.filename) {
     fileLoc = event.filename;
     if (event.lineno !== undefined) {
-      fileLoc += `:${event.lineno}`;
+      fileLoc += ` [:${event.lineno}`;
       if (event.colno !== undefined) {
         fileLoc += `:${event.colno}`;
       }
+      fileLoc += `]`;
     }
   }
   createNewErrorOverlay({