Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add runtime error overlay reporting #1142

Merged
merged 1 commit into from
Sep 28, 2020
Merged

add runtime error overlay reporting #1142

merged 1 commit into from
Sep 28, 2020

Conversation

FredKSchott
Copy link
Owner

Changes

  • Cleans up our current HMR build error reporting
  • Adds runtime error reporting via error overlays

Screen Shot 2020-09-27 at 1 48 52 PM

Testing

  • Tested manually.

@FredKSchott FredKSchott requested a review from a team as a code owner September 27, 2020 21:02
@vercel
Copy link

vercel bot commented Sep 27, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/pxgm2riti
✅ Preview: https://snowpack-git-runtime-error-reports.pikapkg.vercel.app

@FredKSchott
Copy link
Owner Author

Merging so that I can get this out with the rest of our error overlay work, but please give a look even after merging!

@FredKSchott FredKSchott merged commit e373499 into master Sep 28, 2020
@FredKSchott FredKSchott deleted the runtime-error-reports branch September 28, 2020 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@FredKSchott