Re-implement dev dependency automatic handling #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/8gkuu8x9s |
FredKSchott
force-pushed
the
wip-auto-reinstall
branch
from
70dfbec
to
949783e
Compare
drwpow
reviewed
Sep 30, 2020
| @@ -21,8 +21,8 @@ exports[`snowpack install config-alias: import-map.json 1`] = ` | |||
| `; | |||
|
|
|||
| exports[`snowpack install config-alias: output 1`] = ` | |||
| "[snowpack] ! installing dependencies… | |||
There was a problem hiding this comment.
RIP ellipsis 😢
(I don’t actually care; it’s just technically correct, but agree it looks bad in monospaced fonts)
drwpow
reviewed
Sep 30, 2020
| } catch (err) { | ||
| logger.error(err.message); | ||
| logger.debug(err.stack); | ||
| process.exit(1); |
drwpow
reviewed
Sep 30, 2020
| @@ -114,10 +114,9 @@ function resolveWebDependency( | |||
| exportMapEntry?.require || | |||
| exportMapEntry; | |||
| if (typeof exportMapValue !== 'string') { | |||
| logger.error( | |||
| throw new Error( | |||
drwpow
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
process.exit()that should have been handle-able exceptions.Testing
PR Walkthrough