Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't resolve lazy file extensions if they are absolute paths/urls #1330

Merged
merged 1 commit into from
Oct 16, 2020
Merged

don't resolve lazy file extensions if they are absolute paths/urls #1330

merged 1 commit into from
Oct 16, 2020

Conversation

FredKSchott
Copy link
Owner

@FredKSchott FredKSchott commented Oct 16, 2020 •
edited

Changes

  • Fixes an issue that the Svelte team was seeing where they had to rewrite ".svelte.js" to ".svelte" themselves (/cc @Rich-Harris)
  • Instead of doing a lazy replace instantly, we now check first if the file extension is known/valid (this is the way the ordering should have been from the start)

Testing

  • Test added.

Docs

  • N/A

@FredKSchott FredKSchott requested a review from a team as a code owner October 16, 2020 02:03
@vercel
Copy link

vercel bot commented Oct 16, 2020 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/2amjpek3p
✅ Preview: https://snowpack-git-fix-import-resolver-autoresolver.pikapkg.vercel.app

@FredKSchott FredKSchott changed the title don't autoresolve imports if they are absolute paths/urls don't resolve lazy file extensions if they are absolute paths/urls Oct 16, 2020
@FredKSchott FredKSchott force-pushed the fix-import-resolver-autoresolver branch from d1b4fa6 to a4b290f Compare October 16, 2020 02:04
@FredKSchott FredKSchott mentioned this pull request Oct 16, 2020
Closed
@FredKSchott FredKSchott force-pushed the fix-import-resolver-autoresolver branch from a4b290f to a8ac2cd Compare October 16, 2020 02:40
@FredKSchott FredKSchott force-pushed the fix-import-resolver-autoresolver branch from a8ac2cd to 1b8aadb Compare October 16, 2020 02:55
@Rich-Harris
Copy link
Contributor

wonderful, this should allow us to close sveltejs/kit#13 as well as sveltejs/kit#14. thank you!

@FredKSchott FredKSchott merged commit 0863a14 into master Oct 16, 2020
@FredKSchott FredKSchott deleted the fix-import-resolver-autoresolver branch October 16, 2020 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FredKSchott @Rich-Harris