Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: native asset module reference style #1358

Merged
merged 1 commit into from
Oct 18, 2020

Conversation

ashwanth1109
Copy link
Contributor

@ashwanth1109 ashwanth1109 commented Oct 18, 2020

Changes

Adds documentation for the native way of referencing asset modules which snowpack supports

Docs preview:
2020-10-19 02_58_25-Snowpack - The faster frontend build tool and 2 more pages - Personal - Microsof

Testing

No tests are added because these are only documentation changes

Docs

Yes

@vercel
Copy link

vercel bot commented Oct 18, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/4e5a4kvx2
✅ Preview: https://snowpack-git-issue-1279.pikapkg.vercel.app

@FredKSchott
Copy link
Owner

LGTM! I might make some small edits post-merge, but overall this is great, thanks for contributing.

If you feel comfortable, I'd also love some docs help for this new support: #1280

@FredKSchott FredKSchott merged commit 1b7c10c into FredKSchott:master Oct 18, 2020
@ashwanth1109
Copy link
Contributor Author

@FredKSchott , thanks for merging. I will definitely look into #1280
I will assign myself to the issue once I get a grasp of the topic and am confident of raising a PR. Is that okay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants