add support for --include scanning bare module specifiers #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before I even made the issue 😋 |
|
Also @FredKSchott I don’t think we ever discussed this (at least I wasn’t thinking about this scenario). This was just a gap that now has been filled! And it’s a great addition. |
drwpow
pushed a commit
that referenced
this pull request
Jul 24, 2020
drwpow
pushed a commit
that referenced
this pull request
Jul 27, 2020
drwpow
pushed a commit
that referenced
this pull request
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off of this discussion (may have been deleted): https://twitter.com/passle_/status/1216052543366758407
Currently,
--includewon't understand bare module specifiers. This was fine for Babel users who could just run it on their outputlib/directory. But, if you are using import maps, you're out of luck.This PR adds support so that import map users can still use
--include. New test added a lot of noise, but the meat of the change is insrc/scan-imports.ts/cc @thepassle