Don't let deepmerge merge instantiated objects #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One for js config files, and one for instantiated objects
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/g91izeq6v |
FredKSchott
approved these changes
Nov 8, 2020
|
No need to update docs IMO, I see this more as a bug fix to something we probably should have been doing from the start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1416
Uses
is-plain-objectpackage and theisMergeableObjectoption indeepmergeto prevent it from copying properties around from non plain objects, which strips method off ofclassinstances at the very least.Testing
snowpack.config.jsfile because it didn't exist yetDocs
TODO: Should docs be updated for this? I'm not sure, but am happy to do that if it makes sense.