plugin-sass: fixes issue with regex not matching imports #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/lgo2b7ti9 |
FredKSchott
reviewed
Dec 11, 2020
plugins/plugin-sass/plugin.js
Outdated
| // check no ext, no underscore: "index" (/a/b/c/foo/index) | ||
| this._markImportersAsChanged(filePathNoExt.replace(/([\\\/])_/, '$1')); | ||
| this._markImportersAsChanged(filePathNoExt.replace(/(.*[\\\/])_/, '$1')); |
There was a problem hiding this comment.
bah, just realized that this will match this:
/foo/_Playground/snowpack-test/src/base.sass
Going to replace with something closer to your original and then merge: \/_(?!.*\/)
✅ /Users/fks/Downloads/_Playground_/snowpack-test/src/_base.sass
✅ /Users/fks/Downloads/_Playground/snowpack-test/src/_base.sass
✅ /Users/fks/Downloads/Playground/snowpack-test/src/_base.sass
🆇 /Users/fks/Downloads/_Playground/snowpack-test/src/base.sass
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
If the folder structure of the project contains "_" the current regex fails to find an entry in the
importedByMap.Because the sass specification allows partials to be imported without the starting "_", the importedByMap could contain entries where the filename doesn't match. This fix ensures that these files will be found, even if the folder structure contains underscores.
old behaviour:
"/a/b/c/_foo_/_index.scss".replace(/([\\\/])_/, '$1') === "/a/b/c/foo_/_index.scss"new behaviour:
"/a/b/c/_foo_/_index.scss".replace(/(.*[\\\/])_/, '$1') === "/a/b/c/_foo_/index.scss"Testing
This was tested manually by trying out different folder- and filenames.
Docs
Bug fix only pull request.