Feat: import.meta.glob and import.meta.globEager support #2881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/32VyjnDKximn3J9U7TKec1MUSMSX |
|
I'm pumped for this :) |
drwpow
reviewed
Mar 16, 2021
drwpow
reviewed
Mar 16, 2021
drwpow
reviewed
Mar 16, 2021
drwpow
reviewed
Mar 17, 2021
natemoo-re
force-pushed
the
feat-glob-import
branch
from
763da24
to
4165227
Compare
drwpow
reviewed
Mar 17, 2021
drwpow
reviewed
Mar 17, 2021
| @@ -486,6 +486,11 @@ export function removeTrailingSlash(path: string) { | |||
| return path.replace(/[/\\]+$/, ''); | |||
| } | |||
|
|
|||
| /** It's `Array.splice`, but for Strings! */ | |||
drwpow
reviewed
Mar 17, 2021
|
|
||
| it('import.meta.glob does not import its own source file', () => { | ||
| expect(stripWS(files['/_dist_/globSelf.js'])).not.toContain('globSelf.js'); | ||
| }); |
There was a problem hiding this comment.
👍🏻 Great tests. These test everything that I can think of. We may have someone requesting x or y for import globs down the line, but I think this is a great first cut (and may be all we ever need for import globs!)
|
Reviewed in person, some notes:
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Following up on #1165, this PR implements
import.meta.globandimport.meta.globEagerwhich mirror Vite's Glob Import support.Testing
Added tests in
test/build/import-globbut these might need to be more thorough? LMK if you can think of any edge cases I'm missing.Docs
TODO