Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to esbuild 0.11 #3224

Closed
wants to merge 1 commit into from

Conversation

ludofischer
Copy link
Contributor

Changes

Update esbuild to 0.11. There's a ton of bug fixes and in the latest esbuild releases: https://github.com/evanw/esbuild/releases, including top-level await support: evanw/esbuild#253

Overall, the build should become compatible with more packages that previously only worked with more established bundlers., for example evanw/esbuild#769

Testing

Relies on current tests as this pull request does not intend to add new features

Docs

At the moment it is an internal change, so it does not require extra documentation.

@vercel
Copy link

vercel bot commented Apr 28, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/3CUwP2nwT9Np63PJsaUwNT9L45KV
✅ Preview: https://snowpack-git-fork-ludofischer-esbuild-11-pikapkg.vercel.app

@drwpow
Copy link
Collaborator

drwpow commented Apr 29, 2021

Thanks for opening! Yes we’d want to update esbuild and take advantage of all the changes. However, we currently use esbuild as our default bundling step, and 0.11.0 contains some backwards-incompatible changes. It does really affect our bundled output by quite a lot, and also changes the options Snowpack passes to esbuild.

All that is to be expected because we’re using an unstable project for bundling, but I’d like to weigh this a bit more and see if this breaks builds for all the people using Snowpack’s built-in bundler.

@ludofischer
Copy link
Contributor Author

All that is to be expected because we’re using an unstable project for bundling, but I’d like to weigh this a bit more and see if this breaks builds for all the people using Snowpack’s built-in bundler.
There are test failures on CI already you could investigate, but I don't think I will be able to work on this migration further, since the tests are very flaky on my machine so I am not going to be able to contribute very efficiently I am going to close this pull request for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants