experimental skip npm install #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @osdevisnot, thanks for contributing. If I read the code correctly, this wouldn't handle anything with a transitive dependency, correct? It looks like it would correctly read each dependency from unpkg, but then if they loaded anything themselves it would 💩 Is there something that unpkg would provide that npm install isn't getting you? Is the idea just to remove the Update: doh, I replied before seeing #34. Lets discuss there instead |
|
Closing this as ROI for frontend only dependencies is not worth the tradeoffs. Also, this PR did not consider compiling transitive dependencies correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.