upgrade Rollup, add back install treeshaking #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FredKSchott
force-pushed
the
rollup-upgrade
branch
2 times, most recently
from
f62df1c
to
c155d40
Compare
FredKSchott
force-pushed
the
rollup-upgrade
branch
from
c155d40
to
8015b1f
Compare
FredKSchott
force-pushed
the
rollup-upgrade
branch
from
ecec191
to
8015b1f
Compare
|
Great stuff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds back our old tree-shaking algorithm to give you even smaller production builds. As an example, this reduced one user's @fluentui/react usage by 80%. You can enable this yourself via
--treeshake, and you can disable via--no-treeshake. Given the amount of testing this got in Snowpack v1, we feel comfortable turning this on by default for builds in the next version.By happy accident, this upgrade also serves a dual-purpose: improved React handling in the latest version of Rollup (we can remove our special workarounds).
One small issue is that namedExports is no longer supported by Rollup. This is ultimately a good thing: it was removed because Rollup got good enough at CJS interop to no longer need it. But, this will cause an error for anyone who defined namedExports in their project config, with instructions to resolve.